Minor thread related improvements to the framework #22173
Conversation
Previously if an exception happened in this code, the iWait would be run (because of its destructor) but the exception would have been lost.
Use a WaitingTaskHolder to properly manage the reference count on the waiting task.
Use WaitingTaskHolder to manage the reference count for the waiting task.
-Moved ServiceRegistry::Operate calls next to functions which need Services -Moved potentially throwing calls into existing try...catch blocks -Switch to using make_functor_task in cases where we do not need a waiting task
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22173/3319 |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
No description provided.