Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enbale TrackTriggerAssociatorClustersStubs in L1TrackTrigger sequence. #22190

Merged
merged 3 commits into from Mar 19, 2018
Merged

Enbale TrackTriggerAssociatorClustersStubs in L1TrackTrigger sequence. #22190

merged 3 commits into from Mar 19, 2018

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Feb 13, 2018 •
edited

PR 93x.
Add TrackTriggerAssociatorClustersStubs in L1TrackTrigger sequence, as done in
master branch (#22261)

Use:
Needed for L1Trigger studies
With PU 200 it takes ~20sec/ev.
Too long, prefer not to run offline in post-production,

Note:
Not adding products to the EventContent (additional total of 1MB/ev at PU 200).


'keep *_TTClusterAssociatorFromPixelDigis_*_*',
'keep *_TTStubAssociatorFromPixelDigis_*_*'

@rekovic
Enbale TrackTriggerAssociatorClustersStubs in L1TrackTrigger sequence…
9d7e0c1 
…, now that it has been fixed. Time: ~20sec/ev on PU200.
@rekovic
Copy link
Contributor Author

rekovic commented Feb 13, 2018

please test

@cmsbuild cmsbuild added this to the CMSSW_9_3_X milestone Feb 13, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 13, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26038/console Started: 2018/02/13 12:30

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 13, 2018 •
edited

A new Pull Request was created by @rekovic for CMSSW_9_3_X.

It involves the following packages:

Configuration/StandardSequences

@cmsbuild, @franzoni, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor Author

rekovic commented Feb 13, 2018

Atn @sviret, @boudoul, @kpedro88

@cmsbuild
Copy link
Contributor

+1
Tested at: 9d7e0c1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22190/26038/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@kpedro88
Copy link
Contributor

assign upgrade

@cmsbuild
Copy link
Contributor

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22190/26038/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 233
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624038
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@kpedro88
Copy link
Contributor

@rekovic should this change also be made in master (10_1_X)?

@rekovic rekovic mentioned this pull request Feb 17, 2018
Merged
@kpedro88
Copy link
Contributor

backport of #22261

@kpedro88
Copy link
Contributor

+1

@rekovic
Revert "Add TTCluster & TTStubAssociatorFromPixelDigis products to Si…
681c884 
…mTrackerFEVTDEBUG EventContent."

This reverts commit 6289537.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

Pull request #22190 was updated. @cmsbuild, @franzoni, @fabiocos, @kpedro88, @davidlange6 can you please check and sign again.

@rekovic
Copy link
Contributor Author

rekovic commented Mar 2, 2018

Reverted adding products to the EventContent till sorted out in the master branch.
PR is now at what was already passing and approved. Test again.

@rekovic
Copy link
Contributor Author

rekovic commented Mar 2, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26440/console Started: 2018/03/02 14:47

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 2, 2018

@rekovic PR title change should be reverted also

@rekovic rekovic changed the title Enbale TrackTriggerAssociatorClustersStubs in L1TrackTrigger sequence. Add products to FEVTDEBUG EventContent. Enbale TrackTriggerAssociatorClustersStubs in L1TrackTrigger sequence. Mar 2, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

+1
Tested at: 681c884
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22190/26440/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22190/26440/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 225
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624046
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 3, 2018

+1

@kpedro88 kpedro88 mentioned this pull request Mar 9, 2018
Closed
@kpedro88
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 4ce1b76 into cms-sw:CMSSW_9_3_X Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok comparison-available operations-pending orp-pending pending-signatures tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_9_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rekovic @cmsbuild @kpedro88 @fabiocos