Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Validation/DTRecHit clients to DQMEDHarvester + update efficiency plots #22199

Merged
merged 3 commits into from Feb 15, 2018
Merged

Migrate Validation/DTRecHit clients to DQMEDHarvester + update efficiency plots #22199

merged 3 commits into from Feb 15, 2018

Conversation

battibass
Copy link

This PR follows up on the migration of the DQM clients of Validation/DTRecHit not touched in PR 22082 (from @fwyzard).

Includes:

  • new classes to handle efficiencies harvesting in plugins/Histograms.h
  • migration of the existing clients to DQMEDHarvester
  • moving the computation of efficiency plots into clients
  • extension of the DTRecHitClients_cfi configuration

Carlo Battilana added 2 commits February 13, 2018 16:10
Migrate clients to DQMEDHarvester + efficiency plots.
5664e43 
Includes:
- new classes to handle efficiencies in plugins/Histograms.h
- migration of the existing clients to DQMEDHarvester
- moving the computation of efficiency plots into clients
- extension of the DTRecHitClients_cfi configuration
Fix : add missing histogram
a223b5c
@cmsbuild cmsbuild added this to the CMSSW_10_1_X milestone Feb 13, 2018
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22199/3346

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22199/3346/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22199/3346/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22199/3348

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @battibass (Carlo Battilana) for master.

It involves the following packages:

Validation/DTRecHits

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 13, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26050/console Started: 2018/02/13 21:44

@cmsbuild
Copy link
Contributor

+1
Tested at: 68ea016
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22199/26050/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22199/26050/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22199/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2465360
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2465190
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.19999999992 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1896d9b into cms-sw:master Feb 15, 2018
schneiml
schneiml reviewed Mar 14, 2018
View reviewed changes
Validation/DTRecHits/python/DTRecHitClients_cfi.py
dtrechitclients = cms.EDAnalyzer("DTRecHitClients")
dt2dsegmentclients = cms.EDAnalyzer("DT2DSegmentClients")
dt4dsegmentclients = cms.EDAnalyzer("DT4DSegmentClients")
dtrechitclients = cms.EDProducer("DTRecHitClients",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: these should go via https://github.com/cms-sw/cmssw/blob/master/DQMServices/Core/python/DQMEDHarvester.py . Not a functional problem for now, and likely not for the future, but a matter of keeping some order in the plugin types.

@battibass battibass deleted the dtRecHitValidationHarvester branch June 8, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schneiml schneiml schneiml left review comments

Assignees
No one assigned
Labels
code-checks-approved comparison-available dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@battibass @cmsbuild @jfernan2 @fabiocos @schneiml