Bug fix: remove empty or undefined methods

[fwyzard]

Remove undefined methods that can lead to vtable link errors.
At the same time, remove unused or empty methods in the same files.

[fwyzard]

type bugfix

[fwyzard]

@cmsbuild please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[fwyzard]

@dmitrijus can you sign this ?

It should be useful to have it integrated ASAP no matter how the DQM migration is done.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22219/3368

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26071/console Started: 2018/02/14 17:56

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

DQM/TrigXMonitor
DQMOffline/CalibCalo
HLTriggerOffline/Egamma

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@mtosi, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 4299ce4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22219/26071/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22219/26071/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22219/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2465360
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2465190
• DQMHistoTests: Total skipped: 169
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.46999999999 KiB( 22 files compared)
• Checked 111 log files, 9 edm output root files, 27 DQM output files

[fabiocos]

@dmitrijus @jfernan2 could you please have a look? Discussing with @fwyzard I understand this fix is a prerequisite for the ongoing migration of DQMEDManalyzers

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1