Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Obsolete Phase2 Tracker (T4) and the corresponding WF (2023D20) #22221

Merged
merged 5 commits into from Feb 23, 2018

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Feb 14, 2018

Greetings
This PR is removing the obsolete phase2 Tracker T4 (flat barrel).
It was included in only one phase2 WF : 2023D20 , which has been removed from runThematrix and from any configuration I could find.
I preserved the matrix ordering.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @boudoul (boudoul) for master.

It involves the following packages:

Configuration/Geometry
Configuration/PyReleaseValidation
Configuration/StandardSequences
DetectorDescription/RegressionTest
Fireworks/Geometry
Geometry/CMSCommonData
Geometry/TrackerCommonData
Geometry/TrackerRecoData
Geometry/TrackerSimData
SLHCUpgradeSimulations/Geometry

@prebello, @Dr15Jones, @ianna, @mdhildreth, @fabozzi, @cmsbuild, @alja, @franzoni, @kpedro88, @civanch, @GurpreetSinghChahal, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @alja, @ebrondol, @ghugo83, @dgulhan, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@boudoul
Copy link
Contributor Author

boudoul commented Feb 14, 2018

@emiglior FYI

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 14, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26074/console Started: 2018/02/14 19:13

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22221/26074/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22221/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017+HARVESTNANOAODMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2465360
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2465190
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.48000000005 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22221/26145/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 20 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2465360
  • DQMHistoTests: Total failures: 181
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2465010
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.34999999991 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@kpedro88
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

@alja @fabozzi @ianna please sign (again)

@fabozzi
Copy link
Contributor

fabozzi commented Feb 20, 2018

+1

@ianna
Copy link
Contributor

ianna commented Feb 20, 2018

+1

@kpedro88
Copy link
Contributor

@alja ping

@fabiocos
Copy link
Contributor

+operations

@fabiocos
Copy link
Contributor

@alja the Fireworks subsystem code change seems to me trivial

@fabiocos
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

it had also been signed by visualization previously before the update to fix a merge conflict....

@fabiocos
Copy link
Contributor

@kpedro88 thanks, I take this as ok and merge

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 69617d4 into cms-sw:master Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants