Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add 2018 HI MC wf 150.0 to the short matrix #22250

Merged
merged 1 commit into from Feb 19, 2018
Merged

add 2018 HI MC wf 150.0 to the short matrix #22250

merged 1 commit into from Feb 19, 2018

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Feb 16, 2018 •
edited

One large mission for sw developments of 2018 is the preparation for HI data taking.
This PR is to add a 2018 HI MC test to the standard tests.

I thought that a heavier event may be a better choice, but then maybe we should instead have more lighter events instead.

@cmsbuild cmsbuild added this to the CMSSW_10_1_X milestone Feb 16, 2018
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@slava77
Copy link
Contributor Author

slava77 commented Feb 16, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22250/3411

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 16, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26124/console Started: 2018/02/16 14:23

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@cmsbuild, @GurpreetSinghChahal, @prebello, @kpedro88, @fabozzi can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @ebrondol, @ghellwig, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 16, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26125/console Started: 2018/02/16 14:43

@prebello
Copy link
Contributor

please test workflow 150.0

@slava77
Copy link
Contributor Author

slava77 commented Feb 16, 2018

please test workflow 150.0

the goal of the PR is to make jenkins run 150.0 by default.
So, this last test request defeats the purpose.

@cmsbuild
Copy link
Contributor

+1
Tested at: 7eb3c4b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22250/26125/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
0ef6a28
cb25b50
4f0a232
239a1ba
411fffd
2889abe
c7fa0d1
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22250/26125/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22250/26125/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@prebello
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22250/26125/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 131 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2465360
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2465190
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.49999999981 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 19, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26160/console Started: 2018/02/19 10:56

@cmsbuild
Copy link
Contributor

+1
Tested at: 7eb3c4b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22250/26160/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22250/26160/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2465360
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2465190
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.03999999994 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@fabiocos
Copy link
Contributor

@slava77 indeed the wf is run without explicitly invoking it

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22250/26160/runTheMatrix-results/150.0_HydjetQ_B12_5020GeV_2018+HydjetQ_B12_5020GeV_2018+DIGIHI2018+RECOHI2018+HARVESTHI2018/

@kpedro88 could you please check and sign or comment?

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3253be1 into cms-sw:master Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed orp-approved pdmv-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_10_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@slava77 @cmsbuild @prebello @fabiocos @kpedro88