New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing SiStripDetIds dependencies on SiStripTKNumbers. Replacing Si… #22251
Removing SiStripDetIds dependencies on SiStripTKNumbers. Replacing Si… #22251
Conversation
…StripDetId by DetId.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22251/3412 |
A new Pull Request was created by @vidalm (Miguel Vidal) for master. It involves the following packages: DPGAnalysis/SiStripTools @cmsbuild, @monttj can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
This is tracked at #19398 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
@alesaggio @OlivierBondu @pieterdavid @boudoul @vidalm technically the code looks ok to me, please comment in case before I merge |
merge |
cc @alesaggio @OlivierBondu @pieterdavid
Removing SiStripDetIds dependencies replaced by DetId objects.
To the experts (@boudoul) please advice if some test is needed to double check that everything works within DPGAnalysis.