Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing SiStripDetIds dependencies on SiStripTKNumbers. Replacing Si… #22251

Merged
merged 1 commit into from Feb 20, 2018

Conversation

vidalm
Copy link
Contributor

@vidalm vidalm commented Feb 16, 2018

cc @alesaggio @OlivierBondu @pieterdavid

Removing SiStripDetIds dependencies replaced by DetId objects.

To the experts (@boudoul) please advice if some test is needed to double check that everything works within DPGAnalysis.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vidalm (Miguel Vidal) for master.

It involves the following packages:

DPGAnalysis/SiStripTools

@cmsbuild, @monttj can you please review it and eventually sign? Thanks.
@ebrondol, @threus, @mmusich, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@pieterdavid
Copy link
Contributor

This is tracked at #19398

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 17, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26142/console Started: 2018/02/17 12:54

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22251/26142/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2465360
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2465190
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.15999999983 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

@alesaggio @OlivierBondu @pieterdavid @boudoul @vidalm technically the code looks ok to me, please comment in case before I merge

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 7366665 into cms-sw:master Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants