Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to HCAL trigger LUTs #22263

Conversation

christopheralanwest
Copy link
Contributor

Backport #22121

This backport is needed for two reasons:

  • To be able to generate HCAL trigger primitive LUTs in 10_0_X using the same procedure as that envisioned for 2018 data-taking
  • To ensure that a consistent set of code+conditions are used even if a newer GT that includes the changes to the HcalLutMetadata in this PR is introduced for 10_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 19, 2018

A new Pull Request was created by @christopheralanwest for CMSSW_10_0_X.

It involves the following packages:

CalibCalorimetry/HcalAlgos
CalibCalorimetry/HcalPlugins
CalibCalorimetry/HcalTPGAlgos
CalibCalorimetry/HcalTPGEventSetup
CalibFormats/HcalObjects
Configuration/AlCa

@ghellwig, @cmsbuild, @arunhep, @cerminar, @nsmith-, @rekovic, @franzoni, @thomreis, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @tocheng, @Martin-Grunewald, @mmusich, @mariadalfonso this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@lpernie
Copy link
Contributor

lpernie commented Feb 19, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 19, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26155/console Started: 2018/02/19 06:13

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22263/26155/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2469361
  • DQMHistoTests: Total failures: 208
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2468984
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.19000000008 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@nsmith-
Copy link
Contributor

nsmith- commented Feb 19, 2018

+1
Comparison looks just like it does in the 10_1_X PR for L1T.

@lpernie
Copy link
Contributor

lpernie commented Feb 19, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 31ae39e into cms-sw:CMSSW_10_0_X Feb 23, 2018
@christopheralanwest christopheralanwest deleted the hcal-tp-all-corrections_10_0_X branch August 21, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants