Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTPPS geometry for 2018 data taking #22264

Merged
merged 24 commits into from Mar 4, 2018
Merged

Conversation

fabferro
Copy link
Contributor

Added CTPPS geometry for 2018 detector configuration.
Moved part of 2017 geometry inside a specific directory.
Use of Data Base as default method to load the Ideal Geometry instead of direct reading of XML files.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26482/console Started: 2018/03/03 16:36

@perrotta
Copy link
Contributor

perrotta commented Mar 3, 2018

abort test
(it was too early: CMSSW_10_1_X_2018-03-02-2300 still used as baseline)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2018

Jenkins tests are aborted.

@perrotta
Copy link
Contributor

perrotta commented Mar 3, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26486/console Started: 2018/03/03 20:04

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22264/26486/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2479021
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2478844
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.8100000001 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Mar 4, 2018

+1

  • CTPPS geometry moved to DB for both 2017 and 2017 configurations: this is the default access in standard sequences
  • xml file access to CTPPS geometry still possible, and files for 2018 geometry are also added with this PR: it will get disabled, and the corresponding xml files removed from the release, as soon as the DB access will be fully debugged

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 4, 2018

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants