New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ECAL pfrechit thresholds eta dependent in all regions, disregarding if ZS of FR (10-1-X) #22265
Allow ECAL pfrechit thresholds eta dependent in all regions, disregarding if ZS of FR (10-1-X) #22265
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22265/3447 |
please test |
The tests are being triggered in jenkins. |
A new Pull Request was created by @amassiro (Andrea Massironi) for master. It involves the following packages: HLTrigger/Configuration @perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
# CMSSW version specific customizations | ||
def customizeHLTforCMSSW(process, menuType="GRun"): | ||
|
||
# add call to action function in proper order: newest last! | ||
# process = customiseFor12718(process) | ||
|
||
process = customiseForEcalTestPR22254Default(process) | ||
process = customiseFor21821(process) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put the calls in order: most recent last!
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22265/3448 |
Pull request #22265 was updated. @perrotta, @cmsbuild, @silviodonato, @slava77, @Martin-Grunewald, @fwyzard can you please check and sign again. |
@amassiro I'm not particularly attached to the old values, but if the new proposed ones are only 10-20% different, the justification for the change is likely rather weak. (as e.g. EB case C) |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
We do not plan to update w.r.t. what is currently committed. On the technical side, we are working on a DB interface for these values, so that we don't need to go through the explicit definition in cmssw, but it is not ready yet, while we would like to have this included so that people can already test the effect of different thresholds on objects performance and HLT. |
Comparison is ready Comparison Summary:
|
On 2/20/18 12:12 PM, Andrea Massironi wrote:
We do not plan to update w.r.t. what is currently committed.
The values that have been commited on github have been already shown and
discussed among POGs representatives. The values are meant to be used
for testing purposes but not for actual data-taking, unless there is a
request by POGs and PAGs. The default value is the same as in the
previous cmssw release (80 MeV and 300 MeV).
On the technical side, we are working on a DB interface for these
values, so that we don't need to go through the explicit definition in
cmssw, but it is not ready yet, while we would like to have this
included so that people can already test the effect of different
thresholds on objects performance and HLT.
OK.
I guess once it's in the DB, I will likely not see somewhat randomly
floating threshold values.
With my last comments I tried to reduce the entropy on a longer time
scale, rather than just committing to stick to the slightly different
values not yet used anywhere but presented a few times in the last week
or so.
|
+1
|
@Martin-Grunewald I assume you are still ok with this PR, could you please sign it again before I merge it as requested? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Allow ECAL pfrechit thresholds eta dependent in all regions, disregarding if they have been read in Zero Suppression (ZS) of Full Readout (FR).
In the previous version we could activate these thresholds only in ZS regions, or de-activate the application of the thresholds everywhere.
With this PR we can activate the thresholds everywhere, by means of the boolean: "applySelectionsToAllCrystals"
HLT customization added as well, given the new parameter added in the pfrechit producer..
In addition, definition of reasonable thresholds that can be used by jetmet/HLT/EGamma/Tau POGs to estimate possible changes in pf-rechit thresholds to adapt to 2018 data-taking conditions.