Remove the TIBDetId, TOBDetId, TIDDetId and TECDetId classes

[pieterdavid]

After having migrated all uses of these classes to TrackerTopology (see #19398 for the full list of PRs), they can be removed now.

CC @OlivierBondu @alesaggio @vidalm

[cmsbuild]

The code-checks are being triggered in jenkins.

[boudoul]

that is a really really great achievement ... Thanks !!!

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22282/3479

[cmsbuild]

A new Pull Request was created by @pieterdavid (Pieter David) for master.

It involves the following packages:

DQM/SiStripHistoricInfoClient
DataFormats/SiStripDetId

@civanch, @vazzolini, @kmaeshima, @mdhildreth, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@hdelanno, @makortel, @rovere, @VinInn, @fioriNTU, @idebruyn, @OlivierBondu, @mmusich, @threus, @ebrondol this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

@pieterdavid we don't have you identified as DQM developer in[1]. Are you working for HDQM or SiStrip DQM? Thanks
[1] https://twiki.cern.ch/twiki/bin/viewauth/CMS/DQMContacts

[fioriNTU]

@jfernan2 I let @pieterdavid reply, but he is a general framework developer trying to optimize our code. I guess he should be in one of your lists already, it is not the first time he pushes something in DQM.

[jfernan2]

@fioriNTU Then I guess it is HDQM, he was not in the list, added now

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26214/console Started: 2018/02/21 17:01

[cmsbuild]

+1
Tested at: 97e09ed
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22282/26214/summary.html

[cmsbuild]

Comparison job queued.

[boudoul]

hi @jfernan2 , this is unfortunately where we reached the limit of the 'list of devoloper' for DQM - @pieterdavid is not a DQM developer , he is a ... developer. Which means that he's developing in many packages, and DQM is one of it when it's needed. For example the DetIds were everywhere in cmssw, so he removed them (on the tracker DPG request) , factorizing packages per packages (to avoid big PR to review) and the DQM packages are part of this process - So you can add him in your list , in hDQM or DQM or any list you want, for sure it doesn't harm but it doesn't make big sense actually ...

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22282/26214/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 28
• DQMHistoTests: Total histograms compared: 2498056
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2497879
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.899999999936 KiB( 23 files compared)
• Checked 115 log files, 9 edm output root files, 28 DQM output files

[pieterdavid]

Hi @jfernan2 , I think your question has been answered already by @fioriNTU and @boudoul : this is part of a tracker DPG EPR coding task that included migrating some code in DQM, commissioning etc. One clarification: this is not an optimization (there should not be a significant impact on performance), but the change was needed because the DetId layouts that were hardcoded in these classes will change for phase2.

[civanch]

+1

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1