Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-structure visualization client configuration #22283

Merged
merged 1 commit into from Feb 21, 2018

Conversation

dmitrijus
Copy link
Contributor

The connect string was incorrectly overriden into 'PromtProd'.
For online DQM, it should it be 'FrontierProd'.

The override was done because 'globalTagConnect' was not passed
to the scenario.visualizationProcessing and the default value was used.

return globalTag +',frontier://PromptProd/CMS_CONDITIONS'

This PR moves loading of the DQM GT configuration before
calling the scenario config and then properly passes GT and connect
to the call.

The connect string was incorrectly overriden into 'PromtProd'.
For online DQM, it should it be 'FrontierProd'.

The override was done because 'globalTagConnect' was not passed
to the scenario.visualizationProcessing and the default value was used.

https://github.com/cms-sw/cmssw/blob/fc7e8c9e38c6569e65e1cd16e37df0f797af82fe/Configuration/DataProcessing/python/Utils.py#L141

This PR moves loading of the DQM GT configuration _before_
calling the scenario config and then properly passes GT and connect
to the call.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@dmitrijus
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 21, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26212/console Started: 2018/02/21 16:31

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dmitrijus (Dmitrijus) for master.

It involves the following packages:

DQM/Integration

@cmsbuild can you please review it and eventually sign? Thanks.
@makortel, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22283/26212/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 28
  • DQMHistoTests: Total histograms compared: 2498056
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497879
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.00999999998 KiB( 23 files compared)
  • Checked 115 log files, 9 edm output root files, 28 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 50cbbaf into cms-sw:master Feb 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants