New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10_0_X] Hcal TP fix ngHE saturation + switch from bare to effective pedestals #22291
[10_0_X] Hcal TP fix ngHE saturation + switch from bare to effective pedestals #22291
Conversation
@cmsbuild |
@abdoulline I don't think that talking to the bot like that will work. Who is the bot's handler, perhaps @smuzaffar? |
@christopheralanwest |
A new Pull Request was created by @christopheralanwest for CMSSW_10_0_X. It involves the following packages: CalibCalorimetry/HcalTPGAlgos @ghellwig, @cmsbuild, @arunhep, @cerminar, @nsmith-, @rekovic, @franzoni, @thomreis, @ggovi, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
ping |
+1 |
please test |
The tests are being triggered in jenkins. |
-1 Tested at: 5e1d6a9 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build ClangBuild
I found an error when building: >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/Utilities/StaticAnalyzers/src/CmsException.cpp >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/Utilities/StaticAnalyzers/src/murmur.c >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/Utilities/StaticAnalyzers/src/dablooms.c >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CalibCalorimetry/CaloTPG/src/CaloTPGTranscoderULUT.cc /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CalibCalorimetry/HcalTPGAlgos/src/HcaluLUTTPGCoder.cc: In member function 'void HcaluLUTTPGCoder::update(const HcalDbService&)': /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CalibCalorimetry/HcalTPGAlgos/src/HcaluLUTTPGCoder.cc:316:26: error: 'is2018OrLater' was not declared in this scope is2018OrLater ? QIE11_LUT_BITMASK : QIE11_LUT_BITMASK_2017; ^~~~~~~~~~~~~ Entering library rule at CaloOnlineTools/HcalOnlineDb Entering library rule at CalibCalorimetry/HcalTPGEventSetup >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CalibCalorimetry/CaloTPG/plugins/CaloTPGTranscoderULUTs.cc
I found a compilation error while trying to compile with clang: >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalLutGenerator.cc >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CaloOnlineTools/HcalOnlineDb/src/ConfigurationDatabaseStandardXMLParser.cc >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CaloOnlineTools/HcalOnlineDb/src/RooGKCounter.cc >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CaloOnlineTools/HcalOnlineDb/src/ConfigurationDatabaseImplXMLFile.cc >> Compiling /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CaloOnlineTools/HcalOnlineDb/src/HCALConfigDB.cc /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CalibCalorimetry/HcalTPGAlgos/src/HcaluLUTTPGCoder.cc:316:26: error: use of undeclared identifier 'is2018OrLater' is2018OrLater ? QIE11_LUT_BITMASK : QIE11_LUT_BITMASK_2017; ^ 1 error generated. gmake: *** [tmp/slc6_amd64_gcc630/src/CalibCalorimetry/HcalTPGAlgos/src/CalibCalorimetryHcalTPGAlgos/HcaluLUTTPGCoder.o] Error 1 >> Compile sequence completed for CMSSW CMSSW_10_0_X_2018-02-22-2300 |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
-1 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Backport #22262
This backport is needed so that analysis of 10_0_X samples, in particular those for Layer-1 calibrations, use the same HCAL TP generation as that anticipated for 2018 data-taking.
Note that #22263 has not yet been merged, but the 10_1_X version of this PR included #22121, so comparison tests will not show exactly identical results as those from #22262.