Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_0_X] Hcal TP fix ngHE saturation + switch from bare to effective pedestals #22291

Conversation

christopheralanwest
Copy link
Contributor

Backport #22262

This backport is needed so that analysis of 10_0_X samples, in particular those for Layer-1 calibrations, use the same HCAL TP generation as that anticipated for 2018 data-taking.

Note that #22263 has not yet been merged, but the 10_1_X version of this PR included #22121, so comparison tests will not show exactly identical results as those from #22262.

@abdoulline
Copy link

@cmsbuild
looks like something got stuck in github machinery for this submission?..

@christopheralanwest
Copy link
Contributor Author

@abdoulline I don't think that talking to the bot like that will work. Who is the bot's handler, perhaps @smuzaffar?

@abdoulline
Copy link

@christopheralanwest
Oups... "missed the target" in a rush...

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 23, 2018

A new Pull Request was created by @christopheralanwest for CMSSW_10_0_X.

It involves the following packages:

CalibCalorimetry/HcalTPGAlgos
CaloOnlineTools/HcalOnlineDb
SimCalorimetry/HcalTrigPrimAlgos

@ghellwig, @cmsbuild, @arunhep, @cerminar, @nsmith-, @rekovic, @franzoni, @thomreis, @ggovi, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

smuzaffar commented Feb 23, 2018

ping
testing webhook and it works. I see the initial call from github to cms-bot failed with "Service timeout error" that is why bot did not recognize this PR.

@nsmith-
Copy link
Contributor

nsmith- commented Feb 23, 2018

+1

@nsmith-
Copy link
Contributor

nsmith- commented Feb 23, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26256/console Started: 2018/02/23 10:51

@cmsbuild
Copy link
Contributor

-1

Tested at: 5e1d6a9

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22291/26256/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

  • Build:

I found an error when building:

>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/Utilities/StaticAnalyzers/src/CmsException.cpp 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/Utilities/StaticAnalyzers/src/murmur.c 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/Utilities/StaticAnalyzers/src/dablooms.c 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CalibCalorimetry/CaloTPG/src/CaloTPGTranscoderULUT.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CalibCalorimetry/HcalTPGAlgos/src/HcaluLUTTPGCoder.cc: In member function 'void HcaluLUTTPGCoder::update(const HcalDbService&)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CalibCalorimetry/HcalTPGAlgos/src/HcaluLUTTPGCoder.cc:316:26: error: 'is2018OrLater' was not declared in this scope
                          is2018OrLater ? QIE11_LUT_BITMASK : QIE11_LUT_BITMASK_2017;
                          ^~~~~~~~~~~~~
Entering library rule at CaloOnlineTools/HcalOnlineDb
Entering library rule at CalibCalorimetry/HcalTPGEventSetup
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CalibCalorimetry/CaloTPG/plugins/CaloTPGTranscoderULUTs.cc 

  • Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 48 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalLutGenerator.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CaloOnlineTools/HcalOnlineDb/src/ConfigurationDatabaseStandardXMLParser.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CaloOnlineTools/HcalOnlineDb/src/RooGKCounter.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CaloOnlineTools/HcalOnlineDb/src/ConfigurationDatabaseImplXMLFile.cc 
>> Compiling  /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CaloOnlineTools/HcalOnlineDb/src/HCALConfigDB.cc 
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_0_X_2018-02-22-2300/src/CalibCalorimetry/HcalTPGAlgos/src/HcaluLUTTPGCoder.cc:316:26: error: use of undeclared identifier 'is2018OrLater'
                         is2018OrLater ? QIE11_LUT_BITMASK : QIE11_LUT_BITMASK_2017;
                         ^
1 error generated.
gmake: *** [tmp/slc6_amd64_gcc630/src/CalibCalorimetry/HcalTPGAlgos/src/CalibCalorimetryHcalTPGAlgos/HcaluLUTTPGCoder.o] Error 1
>> Compile sequence completed for CMSSW CMSSW_10_0_X_2018-02-22-2300


@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@nsmith-
Copy link
Contributor

nsmith- commented Feb 23, 2018

-1
@christopheralanwest should I test with #22263 ?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26303/console Started: 2018/02/26 11:24

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22291/26303/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2469334
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2469157
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.24000000011 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@nsmith-
Copy link
Contributor

nsmith- commented Feb 26, 2018

+1
As promised, comparison failure is now much smaller, and is limited to 2018, as we saw in 10_1_X.

@ggovi
Copy link
Contributor

ggovi commented Feb 27, 2018

+1

@lpernie
Copy link
Contributor

lpernie commented Feb 27, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 3, 2018

+1

@cmsbuild cmsbuild merged commit 063c90a into cms-sw:CMSSW_10_0_X Mar 3, 2018
@christopheralanwest christopheralanwest deleted the hcal-tp-fix-saturation_10_0_X branch August 21, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants