Fixed segmentation violation in PhysicsTools/SelectorUtils/interface/PFJetIDSelectionFunctor in case subjets are of type pat::Jet

[veelken]

fixed segmentation violation that occurred in subjet analyses in case a pat::Jet had daughters of type pat::Jet
(previous code only handled the case that daughters of pat::Jet were of type reco::PFJet)

[cmsbuild]

A new Pull Request was created by @veelken (Christian Veelken) for CMSSW_9_4_X.

It involves the following packages:

PhysicsTools/SelectorUtils

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from Fixed segmentation violation in PhysicsTools/SelectorUtils/interface/PFJetIDSelectionFunctor in case subjets are of type pat::Jet #22298

[perrotta]

please test

[perrotta]

please @veelken : replace the title of this PR with something a bit more descriptive

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26229/console Started: 2018/02/22 09:31

[veelken]

I have updated the title

[cmsbuild]

+1
Tested at: bf5c417
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22294/26229/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b26c4cc
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22294/26229/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22294/26229/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22294/26229/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2718773
• DQMHistoTests: Total failures: 100
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2718511
• DQMHistoTests: Total skipped: 162
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
• Checked 107 log files, 9 edm output root files, 26 DQM output files

[perrotta]

backport of #22298

[perrotta]

+1

• Identical to Fixed segmentation violation in PhysicsTools/SelectorUtils/interface/PFJetIDSelectionFunctor in case subjets are of type pat::Jet #22298 in the master
• The fix acts as wanted
• No differences expected in jenkins tests, none observed

[arizzi]

@fabiocos as the master equivalent is now merged please consider also merging this as it is needed for analysis (if there is any reason against that let us know and we will move this PR on the AN branch)

[fabiocos]

+1

[fabiocos]

merge