Fix bug in candidate seeded mode of AreaSeededTrackingRegionsBuilder

[JanFSchulte]

This PR fixes a bug in the candidate seeded option. I noticed that when the number of candidates is zero, the current implementation falls back to running the recovery in the full pixel volume, which is of course not desired. This PR fixes this with a proper check if the candidate seeded option is on.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22310/3514

[cmsbuild]

A new Pull Request was created by @JanFSchulte (Jan-Frederik Schulte) for master.

It involves the following packages:

RecoTracker/TkTrackingRegions

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

If it is only about using reco::Track instread of reco::Candidate (I didn't look closely all changes), there is ChargedCandidateProducer https://github.com/cms-sw/cmssw/blob/master/CommonTools/RecoAlgos/plugins/ChargedCandidateProducer.cc which produces reco::RecoChargedCandidate

cmssw/DataFormats/RecoCandidate/interface/RecoChargedCandidate.h

Line 15 in 5c4d67c

class RecoChargedCandidate : public RecoCandidate {

from reco::Tracks. Maybe it would be easier to use than copy-pasting code around?

[JanFSchulte]

@makortel Oh, that looks useful indeed and I will use it to simplify the PR

[makortel]

There is also ConcreteChargedCandidateProducer that apparently is already used in HLT (but I'm not too familiar with their differences).

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22310/3517

[cmsbuild]

Pull request #22310 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[JanFSchulte]

@makortel 99% of the PR were indeed not needed. What remains is the bug that the full pixel volume is used if the number of candidates is zero in candidate seeded mode, which still needs to be fix.

[makortel]

@JanFSchulte If it is not too much of a trouble, could you squash your 3 commits to 1? I think in this case the commit history simplification would be well justified.

[JanFSchulte]

@makortel Is there fancy git magic for this, or do I just create a new PR with a single commit? (which is no problem)

[makortel]

See e.g. http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html and then force-push the same branch.

[cmsbuild]

The code-checks are being triggered in jenkins.

[JanFSchulte]

Neat. Thanks for the instructions.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22310/3518

[cmsbuild]

Pull request #22310 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[makortel]

@cmsbuild, please test

Thanks Jan.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26248/console Started: 2018/02/22 22:03

[cmsbuild]

+1
Tested at: 8aa9975
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22310/26248/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22310/26248/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 28
• DQMHistoTests: Total histograms compared: 2498056
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2497879
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.03000000001 KiB( 23 files compared)
• Checked 115 log files, 9 edm output root files, 28 DQM output files

[perrotta]

@JanFSchulte : (just to know it) what is it supposed to happen when the number of candidates is zero and the method returns a nullptr?

[JanFSchulte]

@perrotta It is caught here https://github.com/JanFSchulte/cmssw/blob/8aa9975b39cc4dd63d67be3d2d7de26a08b8ff58/RecoTracker/TkTrackingRegions/plugins/AreaSeededTrackingRegionsBuilder.cc#L70 and no region is actually added to the result of the producer.

[perrotta]

+1

• The code acts as planned and fixes the candidate Seeded option for automated doublet recovery (not used in offline reco, but proposed for HLT tracking) when there are zero candidates

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1