Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last use of Reflex::CollFuncTable #2233

Merged
merged 1 commit into from Jan 29, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jan 29, 2014

This pull request fixes the cause of the exception that currently causes all ROOT6 relvals to fail. This request replaces the last use of Reflex::CollFuncTable with the ROOT class TVirtualCollectionProxy.

It is not yet known whether the relvals will now pass, or fail on a later error.

NOTE: The changes to StlContainerHandler.* are much less extensive than they appear here. This is because the files were also converted from DOS to UNIX format by removing the trailing carriage returns. Using the "-b" flag with git diff will show the actual changes.

Please merge this before the next ROOT6 IB unless there are obvious problems.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_1_ROOT6_X.

Remove last use of Reflex::CollFuncTable

It involves the following packages:

CondCore/ORA

@ggovi, @cmsbuild, @apfeiffer1, @Degano, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

davidlt added a commit that referenced this pull request Jan 29, 2014
Remove last use of Reflex::CollFuncTable
@davidlt davidlt merged commit ffd182a into cms-sw:CMSSW_7_1_ROOT6_X Jan 29, 2014
@wmtan wmtan deleted the ReplaceCollFuncTable branch January 31, 2014 03:52
@cmsbuild
Copy link
Contributor

ggovi pushed a commit to ggovi/cmssw that referenced this pull request Jan 11, 2017
…datePede

Updated Pede external to V04-03-04.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants