New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fix for different indexing convention in early uGT prescale columns #22332
Add fix for different indexing convention in early uGT prescale columns #22332
Conversation
A new Pull Request was created by @apana (Leonard Apanasvich) for CMSSW_9_4_MAOD_X. It involves the following packages: L1Trigger/L1TGlobal @nsmith-, @cmsbuild, @thomreis, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
backport of #22314 |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_MAOD_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
(ok. discussed the issue with @apana ) |
Already merged successfully in the master branch |
+1 |
Add protection against potential crashes when looking up prescale values in MC datasets made with early versions of the uGT emulator (before the prescale tables were added to the db). The early versions used a different indexing convention for the columns.