Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for different indexing convention in early uGT prescale columns #22332

Conversation

apana
Copy link
Contributor

@apana apana commented Feb 23, 2018

Add protection against potential crashes when looking up prescale values in MC datasets made with early versions of the uGT emulator (before the prescale tables were added to the db). The early versions used a different indexing convention for the columns.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 23, 2018

A new Pull Request was created by @apana (Leonard Apanasvich) for CMSSW_9_4_MAOD_X.

It involves the following packages:

L1Trigger/L1TGlobal

@nsmith-, @cmsbuild, @thomreis, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@perrotta
Copy link
Contributor

backport of #22314

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 24, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26289/console Started: 2018/02/24 10:53

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22332/26289/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2718773
  • DQMHistoTests: Total failures: 111
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2718500
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 107 log files, 9 edm output root files, 26 DQM output files

@slava77
Copy link
Contributor

slava77 commented Feb 26, 2018

@rekovic @thomreis @nsmith-
l1 signature is missing for this PR.
Please check.
This is needed for integration of #22132
Thank you.

@rekovic
Copy link
Contributor

rekovic commented Feb 26, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_MAOD_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@rekovic
Copy link
Contributor

rekovic commented Feb 26, 2018

(ok. discussed the issue with @apana )

@fabiocos
Copy link
Contributor

Already merged successfully in the master branch

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 18cc310 into cms-sw:CMSSW_9_4_MAOD_X Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants