Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one::OutputModules optionally called for Run or LuminosityBlock #22333

Merged

Conversation

Dr15Jones
Copy link
Contributor

The one::OutputModules now only get begin/end transition calls for Run or LuminosityBlocks if the module explicitly requests them. This avoid unnecessary synchronization when using concurrent LuminosityBlocks.
The writeRun and writeLuminosityBlocks were always handed separately from the the other transition calls and are unaffected.

The one::OutputModules now only get begin/end transition calls for Run or LuminosityBlocks if the module explicitly requests them. This avoid unnecessary synchronization when using concurrent LuminosityBlocks.
The writeRun and writeLuminosityBlocks were always handed separately from the the other transition calls and are unaffected.
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26282/console Started: 2018/02/23 22:55

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework
FWCore/Integration

@cmsbuild can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

@smuzaffar the tests for this pull request have taken 3 days. Is there a problem?

@smuzaffar
Copy link
Contributor

please test
@Dr15Jones , job was killed after 10 hours. I have restarted it

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26323/console Started: 2018/02/26 18:07
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26324/console Started: 2018/02/26 18:08

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22333/26324/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22333/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2500248
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2500071
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.949999999953 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit da04ee6 into cms-sw:master Feb 27, 2018
@Dr15Jones Dr15Jones deleted the optionallyCallRunLumiForOutputModules branch February 27, 2018 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants