New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
one::OutputModules optionally called for Run or LuminosityBlock #22333
one::OutputModules optionally called for Run or LuminosityBlock #22333
Conversation
The one::OutputModules now only get begin/end transition calls for Run or LuminosityBlocks if the module explicitly requests them. This avoid unnecessary synchronization when using concurrent LuminosityBlocks. The writeRun and writeLuminosityBlocks were always handed separately from the the other transition calls and are unaffected.
The code-checks are being triggered in jenkins. |
please test |
+1 |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22333/3548 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: FWCore/Framework @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@smuzaffar the tests for this pull request have taken 3 days. Is there a problem? |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
The one::OutputModules now only get begin/end transition calls for Run or LuminosityBlocks if the module explicitly requests them. This avoid unnecessary synchronization when using concurrent LuminosityBlocks.
The writeRun and writeLuminosityBlocks were always handed separately from the the other transition calls and are unaffected.