Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking on pixel phase1 client #22336

Merged
merged 3 commits into from Mar 7, 2018

Conversation

akhatiwa
Copy link
Contributor

Adding tracking information merging special client pixel_timingScan_dqm_sourceclient-live_cfg.py with pixel_dqm_sourceclient-live_cfg.py. Needed to modify SiPixelPhase1OnlineDQM_Timing_cff.py for the same purpose. CMSSW release: CMSSW_10_1_X_2018-02-22-1100.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @akhatiwa for master.

It involves the following packages:

DQM/Integration
DQM/SiPixelPhase1Config

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@batinkov, @hdelanno, @makortel, @fioriNTU, @thomreis, @idebruyn, @threus this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@threus
Copy link
Contributor

threus commented Feb 26, 2018

@akhatiwa please back port to 10_0_X (based on 10_0_0) if you need it in DQM production at P5 before 10_1_0 is out.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #22336 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

@akhatiwa
Copy link
Contributor Author

akhatiwa commented Mar 2, 2018

Hi @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien, would you please check and sign the pull request. Thanks, Ajeeta

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26571/console Started: 2018/03/06 18:11

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22336/26571/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2479021
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2478844
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.22999999995 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Mar 7, 2018

+1

@cmsbuild cmsbuild merged commit 2370dfe into cms-sw:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants