Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in MET tool when reclustering jets and MET on the fly [backport] #22345

Merged
merged 2 commits into from Mar 10, 2018

Conversation

gouskos
Copy link
Contributor

@gouskos gouskos commented Feb 26, 2018

Backporting #22273 in 94X for legacy reminiAOD.

This PR fixes an issue with the MET tool when trying to recluster jets/MET on the fly.
It does not change the data content
Package modified: PhysicsTools/PatUtils/

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2018

A new Pull Request was created by @gouskos for CMSSW_9_4_MAOD_X.

It involves the following packages:

PhysicsTools/PatUtils

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdamgov, @jdolen, @nhanvtran, @gpetruc, @gkasieczka, @schoef, @ferencek, @mverzett, @mariadalfonso, @pvmulder, @seemasharmafnal, @JyothsnaKomaragiri this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Feb 26, 2018

backport of #22273

@slava77
Copy link
Contributor

slava77 commented Feb 26, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26316/console Started: 2018/02/26 16:16

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22345/26316/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2718773
  • DQMHistoTests: Total failures: 100
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2718511
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 107 log files, 9 edm output root files, 26 DQM output files

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

Pull request #22345 was updated. @perrotta, @monttj, @cmsbuild, @slava77, @gpetruc, @arizzi can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Mar 7, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26673/console Started: 2018/03/07 21:55

@slava77
Copy link
Contributor

slava77 commented Mar 8, 2018

@cmsbuild please test

the last attempt failed with 01:05:43 ssl.SSLError: The read operation timed out and a bunch of other errors

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26680/console Started: 2018/03/08 03:08

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22345/26680/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2718773
  • DQMHistoTests: Total failures: 98
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2718513
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 107 log files, 9 edm output root files, 26 DQM output files

@slava77
Copy link
Contributor

slava77 commented Mar 8, 2018

+1

for #22345 19f174c

  • backport of the master version is correct
  • the impact of this PR is limited to somewhat special setups in analysis workflows
  • jenkins tests pass and comparisons show no differences as expected

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit fb6a408 into cms-sw:CMSSW_9_4_MAOD_X Mar 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants