Initial commit for new PF threshold DB object #22346

argiro · 2018-02-26T12:13:44Z

Migration of Ecal PF thresholds from python-based to DB - based

cmsbuild · 2018-02-26T12:14:01Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-02-26T12:17:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22346/3563

cmsbuild · 2018-02-26T12:17:27Z

A new Pull Request was created by @argiro for master.

It involves the following packages:

CondCore/EcalPlugins
CondFormats/DataRecord
CondFormats/EcalObjects
CondTools/Ecal

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @ggovi, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @seemasharmafnal, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

lpernie · 2018-02-26T13:40:29Z

please test

cmsbuild · 2018-02-26T13:40:45Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26307/console Started: 2018/02/26 15:28

cmsbuild · 2018-02-26T16:32:47Z

+1
Tested at: 76d8a57
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22346/26307/summary.html

cmsbuild · 2018-02-26T16:32:50Z

Comparison job queued.

cmsbuild · 2018-02-26T18:12:08Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22346/26307/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22346/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 29
DQMHistoTests: Total histograms compared: 2500248
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2500071
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.14999999988 KiB( 23 files compared)
Checked 118 log files, 9 edm output root files, 29 DQM output files

lpernie · 2018-02-26T21:21:41Z

+1

ggovi · 2018-02-27T14:23:00Z

+1

cmsbuild · 2018-02-27T14:23:18Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-02-27T14:39:17Z

+1

smuzaffar · 2018-02-28T13:15:27Z

CondTools/Ecal/test/BuildFile.xml

-  <test name="EcalTPGCrystalStatus_O2O_test" command="EcalTPGCrystalStatus_O2O_test.sh"/>
-  <test name="EcalTPGTowerStatus_O2O_test" command="EcalTPGTowerStatus_O2O_test.sh"/>
-  <test name="EcalADCToGeV_update_test" command="EcalADCToGeV_update_test.sh"/>
-  <test name="EcalIntercalibConstants_O2O_test" command="EcalIntercalibConstants_O2O_test.sh"/>


@ggovi , was this removal of tests on purpose?

@smuzaffar thanks a lot to spot this!!
@argiro please restore the tests, we are relying on these tests for the production O2Os = VERY CRITICAL

@ggovi , I had made a PR #22384 to restore these.

argiro · 2018-02-28T16:33:16Z

Hi, the removal was probably unintentional, but not critical ..

…

On 28 Feb 2018, at 14:15, Malik Shahzad Muzaffar ***@***.***> wrote: @smuzaffar commented on this pull request. In CondTools/Ecal/test/BuildFile.xml: > - <test name="EcalTPGWeightIdMap_O2O_test" command="EcalTPGWeightIdMap_O2O_test.sh"/> - <test name="EcalTPGWeightGroup_O2O_test" command="EcalTPGWeightGroup_O2O_test.sh"/> - <test name="EcalTPGSlidingWindow_O2O_test" command="EcalTPGSlidingWindow_O2O_test.sh"/> - <test name="EcalTPGPhysicsConst_O2O_test" command="EcalTPGPhysicsConst_O2O_test.sh"/> - <test name="EcalTPGLutIdMap_O2O_test" command="EcalTPGLutIdMap_O2O_test.sh"/> - <test name="EcalTPGPedestals_O2O_test" command="EcalTPGPedestals_O2O_test.sh"/> - <test name="EcalTPGLutGroup_O2O_test" command="EcalTPGLutGroup_O2O_test.sh"/> - <test name="EcalTPGLinearizationConst_O2O_test" command="EcalTPGLinearizationConst_O2O_test.sh"/> - <test name="EcalTPGFineGrainTowerEE_O2O_test" command="EcalTPGFineGrainTowerEE_O2O_test.sh"/> - <test name="EcalTPGFineGrainStripEE_O2O_test" command="EcalTPGFineGrainStripEE_O2O_test.sh"/> - <test name="EcalTPGFineGrainEBIdMap_O2O_test" command="EcalTPGFineGrainEBIdMap_O2O_test.sh"/> - <test name="EcalTPGFineGrainEBGroup_O2O_test" command="EcalTPGFineGrainEBGroup_O2O_test.sh"/> - <test name="EcalTPGCrystalStatus_O2O_test" command="EcalTPGCrystalStatus_O2O_test.sh"/> - <test name="EcalTPGTowerStatus_O2O_test" command="EcalTPGTowerStatus_O2O_test.sh"/> - <test name="EcalADCToGeV_update_test" command="EcalADCToGeV_update_test.sh"/> - <test name="EcalIntercalibConstants_O2O_test" command="EcalIntercalibConstants_O2O_test.sh"/> @ggovi , is this removal of tests on purpose? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ggovi · 2018-02-28T16:55:06Z

hold

cmsbuild · 2018-02-28T16:55:23Z

Pull request has been put on hold by @ggovi
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

ggovi · 2018-02-28T16:57:25Z

@argiro probably a rebase would be a good option

smuzaffar · 2018-02-28T16:59:53Z

@ggovi , this PR has already been merged, so no point putting a hold on it :-)
I have made a PR #22384 to get these tests back

argiro · 2018-02-28T17:03:02Z

thanks !

…

On 28 Feb 2018, at 17:59, Malik Shahzad Muzaffar ***@***.***> wrote: @ggovi , this PR has already been merged, so no point putting a hold on it :-) I have made a PR #22384 to get these tests back — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ggovi · 2018-03-01T14:38:46Z

@argiro
this PR has reverted also CondTools/Ecal/python/updateADCToGeV_test.py
CondTools/Ecal/python/updateIntercali_test.py

ggovi · 2018-03-01T14:42:11Z

@argiro please check again if more changes are unintended

argiro · 2018-03-01T16:49:47Z

I am asking Francesca, who's the real author of the code .. #22346 (comment)

…

On 1 Mar 2018, at 15:42, ggovi ***@***.***> wrote: @argiro please check again if more changes are unintended — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. @argiro this PR has reverted also CondTools/Ecal/python/updateADCToGeV_test.py CondTools/Ecal/python/updateIntercali_test.py

argiro · 2018-03-02T08:36:25Z

sorry, it must have been a mistake. Please leave the original version. thanks Francesca On Thu, Mar 1, 2018 at 5:49 PM, Stefano Argiro' <stefano.argiro@cern.ch> wrote:

…

I am asking Francesca, who's the real author of the code .. #22346 (comment) > On 1 Mar 2018, at 15:42, ggovi ***@***.***> wrote: > > @argiro please check again if more changes are unintended > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > > > @argiro > this PR has reverted also CondTools/Ecal/python/updateADCToGeV_test.py > CondTools/Ecal/python/updateIntercali_test.py

Initial commit for new PF threshold DB object

76d8a57

cmsbuild added this to the CMSSW_10_1_X milestone Feb 26, 2018

cmsbuild added alca-pending code-checks-pending comparison-pending db-pending orp-pending pending-signatures tests-pending labels Feb 26, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 26, 2018

cmsbuild added tests-started and removed tests-pending labels Feb 26, 2018

cmsbuild added tests-approved and removed tests-started labels Feb 26, 2018

cmsbuild added comparison-available and removed comparison-pending labels Feb 26, 2018

cmsbuild added alca-approved and removed alca-pending labels Feb 26, 2018

cmsbuild removed the db-pending label Feb 27, 2018

cmsbuild removed the pending-signatures label Feb 27, 2018

cmsbuild added db-approved fully-signed labels Feb 27, 2018

cmsbuild added orp-approved and removed orp-pending labels Feb 27, 2018

cmsbuild merged commit ed7a65b into cms-sw:master Feb 27, 2018

smuzaffar mentioned this pull request Feb 28, 2018

changes included from 10.1.X devel IB for oracle occi test #22384

Merged

smuzaffar reviewed Feb 28, 2018

View reviewed changes

cmsbuild added hold pending-signatures and removed fully-signed labels Feb 28, 2018

ggovi mentioned this pull request Mar 1, 2018

Add back revered changes #22400

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial commit for new PF threshold DB object #22346

Initial commit for new PF threshold DB object #22346

argiro commented Feb 26, 2018

cmsbuild commented Feb 26, 2018

cmsbuild commented Feb 26, 2018

cmsbuild commented Feb 26, 2018

lpernie commented Feb 26, 2018

cmsbuild commented Feb 26, 2018 •

edited

cmsbuild commented Feb 26, 2018

cmsbuild commented Feb 26, 2018

cmsbuild commented Feb 26, 2018

lpernie commented Feb 26, 2018

ggovi commented Feb 27, 2018

cmsbuild commented Feb 27, 2018

fabiocos commented Feb 27, 2018

smuzaffar Feb 28, 2018 •

edited

ggovi Feb 28, 2018

smuzaffar Feb 28, 2018

argiro commented Feb 28, 2018 via email

ggovi commented Feb 28, 2018

cmsbuild commented Feb 28, 2018

ggovi commented Feb 28, 2018

smuzaffar commented Feb 28, 2018

argiro commented Feb 28, 2018 via email

ggovi commented Mar 1, 2018

ggovi commented Mar 1, 2018

argiro commented Mar 1, 2018 via email

argiro commented Mar 2, 2018 via email

Initial commit for new PF threshold DB object #22346

Initial commit for new PF threshold DB object #22346

Conversation

argiro commented Feb 26, 2018

cmsbuild commented Feb 26, 2018

cmsbuild commented Feb 26, 2018

cmsbuild commented Feb 26, 2018

lpernie commented Feb 26, 2018

cmsbuild commented Feb 26, 2018 • edited

cmsbuild commented Feb 26, 2018

cmsbuild commented Feb 26, 2018

cmsbuild commented Feb 26, 2018

lpernie commented Feb 26, 2018

ggovi commented Feb 27, 2018

cmsbuild commented Feb 27, 2018

fabiocos commented Feb 27, 2018

smuzaffar Feb 28, 2018 • edited

Choose a reason for hiding this comment

ggovi Feb 28, 2018

Choose a reason for hiding this comment

smuzaffar Feb 28, 2018

Choose a reason for hiding this comment

argiro commented Feb 28, 2018 via email

ggovi commented Feb 28, 2018

cmsbuild commented Feb 28, 2018

ggovi commented Feb 28, 2018

smuzaffar commented Feb 28, 2018

argiro commented Feb 28, 2018 via email

ggovi commented Mar 1, 2018

ggovi commented Mar 1, 2018

argiro commented Mar 1, 2018 via email

argiro commented Mar 2, 2018 via email

cmsbuild commented Feb 26, 2018 •

edited

smuzaffar Feb 28, 2018 •

edited