Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT migration to 10_0_3 template (10_0_X) #22360

Merged
merged 1 commit into from Mar 3, 2018

Conversation

Martin-Grunewald
Copy link
Contributor

HLT migration to 10_0_3 template (10_0_X)
Based on CMSSW_10_0_3

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2018

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_10_0_X.

It involves the following packages:

HLTrigger/Configuration

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @geoff-smith, @jalimena this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

backport of #22359

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26326/console Started: 2018/02/26 18:25

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22360/26326/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2468374
  • DQMHistoTests: Total failures: 1543
  • DQMHistoTests: Total nulls: 56
  • DQMHistoTests: Total successes: 2466606
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.04000000001 KiB( 21 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 3, 2018

+1

@cmsbuild cmsbuild merged commit 809382b into cms-sw:CMSSW_10_0_X Mar 3, 2018
@fabiocos
Copy link
Contributor

@Martin-Grunewald this PR is effectively changing the event content for step2, was this expected?

@Martin-Grunewald
Copy link
Contributor Author

Martin-Grunewald commented Mar 12, 2018

Not explicitly (ie, no change to HLT-related keep sequences in the EventContent definition); at most
indirectly due to changes in the menu (more or less instances of the same persistent classes).
(It contains menu developments in addition).

@Martin-Grunewald Martin-Grunewald deleted the HLT100XmigrationTo1003 branch November 17, 2018 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants