OutputModules now write Run and LuminosityBlocks asynchronously

[Dr15Jones]

The framework now has OutputModules write Run and LuminosityBlocks in an asynchronous manner. The necessary serialization for legacy, one and limited modules is also applied.

This fixes a bug when using concurrent LuminosityBlocks.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22365/3576

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework
FWCore/Integration

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26332/console Started: 2018/02/27 02:39

[cmsbuild]

-1

Tested at: ee17acb

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
44aaf25
4fb710b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22365/26332/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22365/26332/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22365/26332/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

• Unit Tests:

I found errors in the following unit tests:

---> test testPythonParameterSet had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
44aaf25
4fb710b
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22365/26332/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22365/26332/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22365/26332/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22365/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2500248
• DQMHistoTests: Total failures: 28
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2500044
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.520000000077 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[Dr15Jones]

+1
The unit test failure is unrelated to this pull request

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[Dr15Jones]

@fabiocos I assume that CMSSW_10_1_0_pre2 has already been set so that this merge is in master but not pre2?

[fabiocos]

@Dr15Jones yes, I waited as we agreed, the pre2 is building since 2 hours and its content is fixed, I discussed this with @smuzaffar earlier today

[fabiocos]

merge

test failure unrelated and understood

[Dr15Jones]

@fabiocos thanks