Fixes to TkMap script

[fioriNTU]

This PR fixes a crash in the Tracker Map production script in the case the DQM Online file for Pixels is not available and prevent to Draw a misleading legend on empty Tracker Maps.

No interference with any production sequences, the code is only used Offline by Tracker shifters.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22370/3581

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22370/3581/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22370/3581/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22370/3584

[cmsbuild]

A new Pull Request was created by @fioriNTU for master.

It involves the following packages:

CommonTools/TrackerMap
DQM/SiStripMonitorClient

@perrotta, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @slava77, @vanbesien can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @hdelanno, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26339/console Started: 2018/02/27 13:39

[cmsbuild]

+1
Tested at: b70aa00
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22370/26339/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22370/26339/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22370/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2499373
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2499196
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.13999999997 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[perrotta]

+1

• This PR is mostly for DQM (used by Tracker shifters, as pointed out in the description)
• The modification in CommonTools/TrackerMap/src/TrackerMap.cc just prevents drawing a misleading legend in a plot when there are empty Tracker Maps
• No change expected in reco, and no effect is visible in the output of jenkins tests

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1