Fix a.clone(b=dict(c=None)) #22413
Fix a.clone(b=dict(c=None)) #22413
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22413/3657 |
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
|
type bugfix |
FWCore/ParameterSet/python/Mixins.py
Outdated
| _modifyParametersFromDict(p, | ||
| value,errorRaiser, | ||
| ("%s.%s" if type(key)==str else "%s[%s]")%(keyDepth,key)) | ||
| for k,v in p.iteritems(): | ||
| setattr(pset,k,v) | ||
| try: | ||
| oldkeys.remove(k) |
There was a problem hiding this comment.
If you switch to oldkeys.discard(k) you do not have to use the try...except
There was a problem hiding this comment.
Thanks, much cleaner with that.
cmsbuild
added
code-checks-pending
tests-pending
and removed
code-checks-approved
tests-started
labels
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22413/3671 |
|
Pull request #22413 was updated. @cmsbuild, @smuzaffar, @Dr15Jones can you please check and sign again. |
|
-1 Tested at: 0ddfde6 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests AddOn
I found errors in the following unit tests: ---> test testPythonParameterSet had ERRORS
I found errors in the following addon tests: |
|
Comparison job queued. |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
-1 Tested at: 5d0988a You can see the results of the tests here: I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testPythonParameterSet had ERRORS |
|
Comparison job queued. |
|
The unit test failure is unrelated to this pull request. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
@fabiocos this didn't get merged for some reason. |
Maybe because of the (unrelated) unit test failure? |
|
@makortel @Dr15Jones yes, I should force it |
|
merge |
I noticed that
did not remove
d.b.c. This PR adds a unit test for this case and attempts to fix it.Tested in CMSSW_10_1_X_2018-02-27-2300, no changes expected (I assume we have not hit this bug before).