SimDataFormats/GeneratorProducts: fix bug found by clang self-move warnings

[gartung]

SimDataFormats/GeneratorProducts/interface/LHEEventProduct.h:32:20: warning: explicitly moving variable of type 'double' to itself [-Wself-move]

[gartung]

@Dr15Jones

[cmsbuild]

The code-checks are being triggered in jenkins.

[Dr15Jones]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22429/3688

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26456/console Started: 2018/03/02 18:41

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

SimDataFormats/GeneratorProducts

@cmsbuild, @efeyazgan, @perrozzi can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: c18e0d4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22429/26456/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22429/26456/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2479021
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2478844
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.10000000011 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[perrozzi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1

[makortel]

Would it make sense to turn the self-move clang warning an error?