Adding an hlt filter for CTPPS local tracks #22446
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22446/3715 |
|
A new Pull Request was created by @cbeiraod (Cristovao da Cruz e Silva) for master. It involves the following packages: HLTrigger/special @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| // system include files | ||
| #include <map> | ||
| #include <iostream> | ||
| #include <memory> |
There was a problem hiding this comment.
The above three includes do not seem to be needed - check and remove!
| useStrip_ = true; | ||
| if(detectorBitset_ & 4) | ||
| useDiamond_ = true; | ||
|
|
There was a problem hiding this comment.
The above is horrible, simply use these three Booleans as bool module parameters and remove detectorBitset.
| // member functions | ||
| // | ||
| bool HLTCTPPSLocalTrackFilter::hltFilter(edm::Event& iEvent, const edm::EventSetup& iSetup, trigger::TriggerFilterObjectWithRefs& filterproduct) const | ||
| { |
There was a problem hiding this comment.
You do not really make use of the HLTfilter functionality, so then it is better to use a standard EDFilter as base class.
| if(useStrip_) filterproduct.addCollectionTag(stripLocalTrackInputTag_); | ||
| if(useDiamond_) filterproduct.addCollectionTag(diamondLocalTrackInputTag_); | ||
| } | ||
|
|
There was a problem hiding this comment.
As above, not used later in your code
| bool accept = true; | ||
|
|
||
| if(arm45Tracks + arm56Tracks < minTracks_ || arm45Tracks < minTracksPerArm_ || arm56Tracks < minTracksPerArm_) | ||
| accept = false; |
There was a problem hiding this comment.
Directly put return false;
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
tests-started
and removed
tests-rejected
tests-pending
labels
|
Comparison is ready Comparison Summary:
|
|
Comparison job queued. |
cmsbuild
added
comparison-pending
tests-approved
and removed
comparison-available
tests-started
labels
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
fully-signed
hlt-approved
and removed
hlt-pending
pending-signatures
labels
|
If you need this urgently, consider a backport PR for CMSSW 10_0. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
This PR implements a first hlt filter using the local track multiplicity from the CT-PPS detector.
The filter allows to set a minimum multiplicity of CT-PPS tracks per event and per arm of the detector, for example this allows to require a coincidence between the two arms. It is also possible to set a maximum multiplicity, per event, arms and roman pot.