Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnlineDQM: Fix RegionalMuonCand comparison processor axis range CMSLITDPG-478 #22452

Merged
merged 1 commit into from Mar 7, 2018

Conversation

stahlleiton
Copy link
Contributor

Solves https://its.cern.ch/jira/browse/CMSLITDPG-478

Description: Change the upper value of the axis range of the two L1TMuon RegionalMuonCand processor histograms from 15.5 to 11.5

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2018

A new Pull Request was created by @stahlleiton (Andre Stahl) for master.

It involves the following packages:

DQM/L1TMonitor

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor

thomreis commented Mar 4, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26496/console Started: 2018/03/05 04:59

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22452/26496/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2479021
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 22
  • DQMHistoTests: Total successes: 2478822
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.990000000093 KiB( 21 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 7, 2018

+1

@cmsbuild cmsbuild merged commit 05e3cfb into cms-sw:master Mar 7, 2018
@stahlleiton stahlleiton deleted the CMSLITDPG_478_Master branch March 7, 2018 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants