Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete integration of HP beamspot workflow for PCL #22461

Merged

Conversation

franzoni
Copy link

@franzoni franzoni commented Mar 5, 2018

backport of #22299

This PR completes the work needed to feed High-Precision beamspot measurements out of PCL to the LHC.

Dedicated workflow names are introduced duplicating the config. w.r.t to the normal workflow to allow for customization of the selections dropping confusing customization functions. (eventually we might drop the old version).

Relvals and ConfigDP tests are updated accordingly.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

A new Pull Request was created by @franzoni (Giovanni Franzoni) for CMSSW_10_0_X.

It involves the following packages:

Calibration/TkAlCaRecoProducers
Configuration/AlCa
Configuration/DataProcessing
Configuration/EventContent
Configuration/PyReleaseValidation
Configuration/StandardSequences

@ghellwig, @prebello, @arunhep, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @cerminar, @GurpreetSinghChahal, @lpernie, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @tocheng, @VinInn, @Martin-Grunewald, @ebrondol, @rovere, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@franzoni
Copy link
Author

franzoni commented Mar 5, 2018

Backport of #22299

@franzoni
Copy link
Author

franzoni commented Mar 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26511/console Started: 2018/03/05 16:20

@franzoni
Copy link
Author

franzoni commented Mar 5, 2018

@cerminar @sarafiorendi @rmanzoni
This is to test the Tier-0 handling of massi files already w/ 10_0

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22461/26511/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2468459
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2468289
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.07999999997 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@lpernie
Copy link
Contributor

lpernie commented Mar 5, 2018

+1

@fabozzi
Copy link
Contributor

fabozzi commented Mar 6, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Mar 6, 2018

+operations

@fabiocos
Copy link
Contributor

fabiocos commented Mar 6, 2018

@kpedro88 this PR is needed for test at P5, could you please check and sign or comment?

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 6, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 6, 2018

+1

@cmsbuild cmsbuild merged commit f6867b9 into cms-sw:CMSSW_10_0_X Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants