Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] HGCAL trigger updates - 1 #22480

Merged

Conversation

jbsauvan
Copy link
Contributor

@jbsauvan jbsauvan commented Mar 6, 2018

This is a backport of #22387, except for the commit that adds the HGCAL TPG in standard sequences, which will be added in a second PR.

jbsauvan and others added 30 commits March 6, 2018 09:05
…lace. Still 2 points need to be fixed: sorting the tc using vector::sort and check if seeds are NN.
Fix for dRNNC2D (to get C2Ds with more than one cell)
… are meant for TCs only. Add some functionality for layer positions
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

-1

  • Build:

I found an error when building:

* The action "install-external+py2-pippkgs_depscipy-toolfile+1.0-ghjeda7" was not completed successfully because Traceback (most recent call last):
File "/build/cmsbld/jenkins/workspace/ib-any-integration/PKGTOOLS/scheduler.py", line 199, in doSerial
result = commandSpec[0](*commandSpec[1:])
File "PKGTOOLS/cmsBuild", line 2776, in installApt
RpmInstallFailed: Failed to install package py2-pippkgs_depscipy-toolfile. Reason:
error: Failed dependencies:
	libhdf5.so.10()(64bit) is needed by external+py2-pippkgs_depscipy+3.0-ghjeda7-1-1.x86_64
	libhdf5_hl.so.10()(64bit) is needed by external+py2-pippkgs_depscipy+3.0-ghjeda7-1-1.x86_64
Reading Package Lists...
Get:1 http://cmsrep.cern.ch cmssw/cms.week0/slc6_amd64_gcc630 external+py2-pippkgs_depscipy-toolfile+1.0-ghjeda7-1-1.slc6_amd64_gcc630.rpm
Building Dependency Tree...


You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3815/26669/summary.html

@smuzaffar
Copy link
Contributor

please test with cms-sw/cmsdist#3815

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3815
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26675/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22480/26675/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 227
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624044
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Mar 8, 2018

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Mar 8, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@rekovic
Copy link
Contributor

rekovic commented Mar 13, 2018

@fabiocos Can we please merge this one.

@kpedro88
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit cd688f8 into cms-sw:CMSSW_9_3_X Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants