Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TopQuarkAnalysis packages: clean up clang warnings: #22495

Merged
merged 1 commit into from Apr 2, 2018
Merged

TopQuarkAnalysis packages: clean up clang warnings: #22495

merged 1 commit into from Apr 2, 2018

Conversation

gartung
Copy link
Member

@gartung gartung commented Mar 6, 2018

TopQuarkAnalysis/TopPairBSM/src/BoostedTopProducer.h:89:20: warning: 'BoostedTopProducer::beginJob' hides overloaded virtual function [-Woverloaded-virtual]
virtual void beginJob(const edm::EventSetup&) ;
^

Remove empty functions.

TopQuarkAnalysis/TopPairBSM/src/BoostedTopProducer.h:89:20: warning: 'BoostedTopProducer::beginJob' hides overloaded virtual function [-Woverloaded-virtual]
       virtual void beginJob(const edm::EventSetup&) ;
                   ^
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

The code-checks are being triggered in jenkins.

@gartung
Copy link
Member Author

gartung commented Mar 6, 2018

@Dr15Jones

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

TopQuarkAnalysis/TopPairBSM

@gpetruc, @cmsbuild, @arizzi, @monttj can you please review it and eventually sign? Thanks.
@jdolen, @kreczko this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26610/console Started: 2018/03/06 21:49

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22495/26610/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2479021
  • DQMHistoTests: Total failures: 1032
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2477813
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1558.81 KiB( 22 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@gartung
Copy link
Member Author

gartung commented Mar 19, 2018

Unrelated timeout error.

@gartung
Copy link
Member Author

gartung commented Mar 23, 2018

@fabiocos please retest

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27069/console Started: 2018/03/23 15:18

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22495/27069/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2498300
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2498123
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.980000000069 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Apr 1, 2018

+1

@fabiocos
Copy link
Contributor

fabiocos commented Apr 2, 2018

merge

@cmsbuild cmsbuild merged commit 1d3cb2b into cms-sw:master Apr 2, 2018
@gartung gartung deleted the TopQuarkAnalysis-clang-warning-cleanup branch April 6, 2018 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants