Gem online dqm #22500

hyunyong · 2018-03-06T21:42:05Z

GEM online DQM

To be done: SQLite DB file for unpacker didn't get GT yet

talk:
https://indico.cern.ch/event/685922/contributions/2814461/attachments/1570331/2476923/GEMDQM05DEC.pdf

@jshlee @andjuo

cmsbuild · 2018-03-06T21:42:22Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-03-06T21:44:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22500/3785

cmsbuild · 2018-03-06T21:44:42Z

A new Pull Request was created by @hyunyong for master.

It involves the following packages:

DQM/GEM
DQM/Integration

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@makortel, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2018-03-07T08:33:22Z

please test

cmsbuild · 2018-03-07T08:33:40Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26631/console Started: 2018/03/07 09:34

dmitrijus · 2018-03-07T08:54:52Z

DQM/GEM/plugins/GEMDQMHarvester.cc

+  void prova(DQMStore::IBooker &ibooker, edm::Run const &, edm::EventSetup const & iSetup);
+  std::string fName;
+  int verbosity;
+  DQMStore *dbe;


please remove this pointer

it was done. This moment we don't use harvester, so I removed all useless things.

dmitrijus · 2018-03-07T08:56:40Z

DQM/GEM/plugins/GEMDQMStatusDigi.cc

+
+//----------------------------------------------------------------------------------------------------
+
+void GEMDQMStatusDigi::dqmBeginRun(edm::Run const &, edm::EventSetup const &)


please remove empty methods, you don't have to define them.

it was done.

cmsbuild · 2018-03-07T09:29:47Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-03-07T09:31:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22500/3799

cmsbuild · 2018-03-07T09:31:54Z

Pull request #22500 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

cmsbuild · 2018-03-07T10:33:37Z

+1
Tested at: c9f4239
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22500/26631/summary.html

cmsbuild · 2018-03-07T17:20:40Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22500/3820

cmsbuild · 2018-03-07T17:21:00Z

Pull request #22500 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

dmitrijus · 2018-03-08T09:00:26Z

+1

cmsbuild · 2018-03-08T09:01:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26691/console Started: 2018/03/08 10:02

cmsbuild · 2018-03-08T09:01:03Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild · 2018-03-08T10:57:37Z

+1
Tested at: 62c0cde
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22500/26691/summary.html

cmsbuild · 2018-03-08T10:57:41Z

Comparison job queued.

fabiocos · 2018-03-08T13:16:09Z

@andjuo @hyunyong @jshlee I understand that the test included in this PR has been used on real cosmics data and with GT 101X_dataRun2_HLT_Candidate_2018_03_07_17_38_52 to show that the unpacker and this DQM code works on real data. Could you please post the results of this test?

hyunyong · 2018-03-08T15:24:58Z

@fabiocos
These slides show GEM online DQM and candidate GT test results.
https://indico.cern.ch/event/711282/contributions/2920924/attachments/1614003/2564012/GEMDPG08MAR.pdf

also, you can download the DQM root file at below link.
https://www.dropbox.com/s/hi1u3p8dzdn1cap/DQM_V0001_GEM_R000310292.root?dl=0

cmsbuild · 2018-03-08T15:28:29Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22500/26691/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 29
DQMHistoTests: Total histograms compared: 2480211
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2480034
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.08000000025 KiB( 22 files compared)
Checked 118 log files, 9 edm output root files, 29 DQM output files

fabiocos · 2018-03-08T21:21:39Z

@hyunyong thanks, let's move this code forward for use at P5. This will allow to further exercise the unpacker on real data before activating it in the regular reconstruction workflows.

fabiocos · 2018-03-08T21:23:08Z

+1

fabiocos · 2018-03-08T21:24:16Z

in order to use it at P5 in the short time scale we need a back-port to 10_0_X

hyunyong added 2 commits March 6, 2018 17:24

1st commit for GEM online DQM

0dacb5a

clean up

c9f4239

cmsbuild added this to the CMSSW_10_1_X milestone Mar 6, 2018

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Mar 6, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 6, 2018

cmsbuild added tests-started and removed tests-pending labels Mar 7, 2018

dmitrijus suggested changes Mar 7, 2018

View reviewed changes

remove unused method

7fcef57

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels Mar 7, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 7, 2018

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Mar 8, 2018

cmsbuild added tests-started and removed tests-pending labels Mar 8, 2018

cmsbuild added tests-approved and removed tests-started labels Mar 8, 2018

cmsbuild added comparison-available and removed comparison-pending labels Mar 8, 2018

cmsbuild added orp-approved and removed orp-pending labels Mar 8, 2018

cmsbuild merged commit 1e44d9f into cms-sw:master Mar 8, 2018

fabiocos mentioned this pull request Mar 8, 2018

[100X] Packing and Unpacking for GEM #22471

Merged

hyunyong mentioned this pull request Mar 11, 2018

[100X] GEM Online DQM #22580

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gem online dqm #22500

Gem online dqm #22500

hyunyong commented Mar 6, 2018 •

edited

cmsbuild commented Mar 6, 2018

cmsbuild commented Mar 6, 2018

cmsbuild commented Mar 6, 2018

jfernan2 commented Mar 7, 2018

cmsbuild commented Mar 7, 2018 •

edited

dmitrijus Mar 7, 2018

hyunyong Mar 7, 2018

dmitrijus Mar 7, 2018

hyunyong Mar 7, 2018

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

dmitrijus commented Mar 8, 2018

cmsbuild commented Mar 8, 2018 •

edited

cmsbuild commented Mar 8, 2018

cmsbuild commented Mar 8, 2018

cmsbuild commented Mar 8, 2018

fabiocos commented Mar 8, 2018

hyunyong commented Mar 8, 2018

cmsbuild commented Mar 8, 2018

fabiocos commented Mar 8, 2018

fabiocos commented Mar 8, 2018

fabiocos commented Mar 8, 2018


		//----------------------------------------------------------------------------------------------------

		void GEMDQMStatusDigi::dqmBeginRun(edm::Run const &, edm::EventSetup const &)

Gem online dqm #22500

Gem online dqm #22500

Conversation

hyunyong commented Mar 6, 2018 • edited

cmsbuild commented Mar 6, 2018

cmsbuild commented Mar 6, 2018

cmsbuild commented Mar 6, 2018

jfernan2 commented Mar 7, 2018

cmsbuild commented Mar 7, 2018 • edited

dmitrijus Mar 7, 2018

Choose a reason for hiding this comment

hyunyong Mar 7, 2018

Choose a reason for hiding this comment

dmitrijus Mar 7, 2018

Choose a reason for hiding this comment

hyunyong Mar 7, 2018

Choose a reason for hiding this comment

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

cmsbuild commented Mar 7, 2018

dmitrijus commented Mar 8, 2018

cmsbuild commented Mar 8, 2018 • edited

cmsbuild commented Mar 8, 2018

cmsbuild commented Mar 8, 2018

cmsbuild commented Mar 8, 2018

fabiocos commented Mar 8, 2018

hyunyong commented Mar 8, 2018

cmsbuild commented Mar 8, 2018

fabiocos commented Mar 8, 2018

fabiocos commented Mar 8, 2018

fabiocos commented Mar 8, 2018

hyunyong commented Mar 6, 2018 •

edited

cmsbuild commented Mar 7, 2018 •

edited

cmsbuild commented Mar 8, 2018 •

edited