EventFilter/CSCRawToDigi: Cleanup for the following clang warnings. Remove ununsed function.

[gartung]

Reverts #22468

[gartung]

@Dr15Jones

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22513/3816

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

EventFilter/CSCRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ptcox, @barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

@gartung did you want to do the revert so that we get the clang warning in order to remind us to do a proper fix in the future?

[gartung]

Yes. DXR reports that this function is never called by any of the subclasses.

[Dr15Jones]

Then how about just removing it all together?

[gartung]

Will do that now.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22513/3817

[cmsbuild]

Pull request #22513 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26663/console Started: 2018/03/07 17:51

[cmsbuild]

+1
Tested at: e93a52f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22513/26663/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
1106ee8
2370dfe
f09ef86
639b9cd
cc1ef20
040b18e
3780bf0
2e2579f
05e3cfb
0ae3f43
910344a
7dd6b84
fb45eaf
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22513/26663/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22513/26663/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22513/26663/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 90 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2480211
• DQMHistoTests: Total failures: 294
• DQMHistoTests: Total nulls: 362
• DQMHistoTests: Total successes: 2479379
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 4117.45 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[slava77]

+1

for #22513 e93a52f

• removal of unused function.
• jenkins tests pass (compilation is enough)

@gartung please edit the PR title to be more representative of the change

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1