[10.1.X] Updates in SiStrip PI classes: activate tests and additional plots for Strip Noise, Gains and Bad Components

[mmusich]

Several updates in the Strip Payload Inspector:

• make the SiStrip PI unit tests actually be exercised;
• add history of min,max and rms of SiStrip ApvGains;
• add Strip Noise comparison by region of mean,rms,min & max by module;
• add Strip Noise aggregate values comparison plots;
• add detailed (by Module, Fiber, APV and Strip) comparison of Strip Bad Components between two IOVs;
• add fraction of bad components to total in Strip Bad Components analysis comparison between two IOVs;

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22523/3831

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/SiStripPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26692/console Started: 2018/03/08 10:43

[cmsbuild]

+1
Tested at: cc0685d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22523/26692/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22523/26692/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2480211
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2480034
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.1900000001 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@mmusich is this code running just in the cpp code modified here in a standalone mode? Or is it part of more general workflows?

[mmusich]

@fabiocos I am not sure to understand your question. This code is not run anywhere in production workflows, but it is used to create the plots displayed in the payload inspector. As such there is no guarantee it stays functional, as it is not probed in relvals, etc.
The file CondCore/SiStripPlugins/test/testSiStripPayloadInspector.cpp used to allow the expert user to test some of the classes in standalone mode, but was not possible to run an actual unit test, due to the fact that before this commit a17b352, only direct oracle connection was supported, which is not supposed to work in the offline world unless reading credentials are supplied.
Now, it is possible to read from fronTier and so it can be made part of a unit test.
Hope this answers your questions.

[fabiocos]

@mmusich this is what I wanted to understand, thanks

[fabiocos]

+1