EventFilter/SiStripRawToDigi: clean up clang warnings: #22536
Conversation
src/EventFilter/SiStripRawToDigi/interface/SiStripFEDBuffer.h:39:20: warning: 'sistrip::FEDBuffer::channelGood' hides overloaded virtual function [-Woverloaded-virtual]
virtual bool channelGood(const uint8_t internalFEDannelNum, const bool doAPVeCheck=true) const;
^
src/EventFilter/SiStripRawToDigi/interface/SiStripFEDBuffer.h:44:20: warning: 'sistrip::FEDBuffer::doChecks' hides overloaded virtual function [-Woverloaded-virtual]
virtual bool doChecks(bool doCRC=true) const;
^
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22536/3854 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22536/3854/git-diff.patch You can run |
| @@ -181,7 +181,7 @@ namespace sistrip { | |||
| try { | |||
| buffer.reset(new sistrip::FEDBuffer(input.data(),input.size())); | |||
| buffer->setLegacyMode(legacy_); | |||
| if (!buffer->doChecks()) { | |||
| if (!buffer->doChecks(bool(1))) { | |||
There was a problem hiding this comment.
How about !buffer->doChecks(true)
|
The code-checks are being triggered in jenkins. |
|
@Dr15Jones code-checks caught that |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22536/3857 |
|
A new Pull Request was created by @gartung (Patrick Gartung) for master. It involves the following packages: EventFilter/SiStripRawToDigi @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22536/3858 |
|
Pull request #22536 was updated. @perrotta, @ghellwig, @vazzolini, @kmaeshima, @arunhep, @cerminar, @dmitrijus, @cmsbuild, @franzoni, @jfernan2, @slava77, @vanbesien, @lpernie can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1
|
|
+1 |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 technical code fixes, no evident effect in test workflows |
src/EventFilter/SiStripRawToDigi/interface/SiStripFEDBuffer.h:39:20: warning: 'sistrip::FEDBuffer::channelGood' hides overloaded virtual function [-Woverloaded-virtual]
virtual bool channelGood(const uint8_t internalFEDannelNum, const bool doAPVeCheck=true) const;
^
src/EventFilter/SiStripRawToDigi/interface/SiStripFEDBuffer.h:44:20: warning: 'sistrip::FEDBuffer::doChecks' hides overloaded virtual function [-Woverloaded-virtual]
virtual bool doChecks(bool doCRC=true) const;
^