Improve event setup usage in HCAL digitization

[kpedro88]

A while ago, @ianna noticed (#19147 (comment)) that HcalDigitizer::checkGeometry() was using more CPU than should be necessary. More recently, a comment by @Dr15Jones (#20666 (comment)) helped me realize how to avoid calling updateGeometry() unnecessarily. I also removed unnecessary copying of objects in HcalShapes. With these changes, @ianna confirms that HcalDigitizer CPU usage is reduced.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22538/3859

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

SimCalorimetry/HcalSimAlgos
SimCalorimetry/HcalSimProducers

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@mariadalfonso this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[kpedro88]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26717/console Started: 2018/03/08 22:40

[cmsbuild]

+1
Tested at: 0f66303
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22538/26717/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22538/26717/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2484711
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2484534
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.21000000007 KiB( 22 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1