Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NVProfilerService: improve handling of module prefetching #22574

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 10, 2018

The display of module prefetching calls is now optional, controlled by the showModulePrefetching parameter.
In the Visual Profile prefetching shows up as light green (or light amber for highlighted modules) to easily distinguish it from the actual event processing.

The display of module prefetching calls is now optional, controlled by
the `showModulePrefetching` parameter.
In te Visual Profile prefetching shows up as light green (or light amber
for highlighted modules) to easily distinguish it from the actual event
processing.
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 10, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 10, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26762/console Started: 2018/03/10 15:41

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

HeterogeneousCore/CUDAServices

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 10, 2018

Note: this works locally, but it will likely fail to build, since the linker check will fail without CUDA installed.

@smuzaffar
Copy link
Contributor

smuzaffar commented Mar 10, 2018

@fwyzard , I noticed that we get this build error (which is then ignored by the edmWriteConfig).

@@@@ Running edmWriteConfigs for HeterogeneousCoreCUDAServicesPlugins
error: edmWriteConfigs caught an exception while loading a plugin library.
The executable will return success (0) so scram will continue,
but no cfi files will be written.
An exception of category 'PluginLibraryLoadError' occurred.
Exception Message:
unable to load /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-03-09-2300/tmp/slc6_amd64_gcc630/src/HeterogeneousCore/CUDAServices/plugins/HeterogeneousCoreCUDAServicesPlugins/libHeterogeneousCoreCUDAServicesPlugins.so because libcuda.so.1: cannot open shared object file: No such file or directory

--- Registered EDM Plugin: HeterogeneousCoreCUDAServicesPlugins

we missing the cuda/lib64/stub in LD_LIBRARY_PATH, was it on purpose?

@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 10, 2018

Indeed, that's what you need scram setup nvidia-drivers for.

The stubs are used by the link step of the compilation, but are not used at run time, since they do not provide any functionality.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22574/26762/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2484711
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2484534
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.870000000039 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8142cc2 into cms-sw:master Mar 13, 2018
@fwyzard fwyzard deleted the NVProfilerService_module_prefetching branch May 17, 2018 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants