New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NVProfilerService: improve handling of module prefetching #22574
NVProfilerService: improve handling of module prefetching #22574
Conversation
The display of module prefetching calls is now optional, controlled by the `showModulePrefetching` parameter. In te Visual Profile prefetching shows up as light green (or light amber for highlighted modules) to easily distinguish it from the actual event processing.
@cmsbuild please test |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22574/3898 |
The tests are being triggered in jenkins. |
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: HeterogeneousCore/CUDAServices @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Comparison job queued. |
Note: this works locally, but it will likely fail to build, since the linker check will fail without CUDA installed. |
@fwyzard , I noticed that we get this build error (which is then ignored by the edmWriteConfig).
we missing the cuda/lib64/stub in LD_LIBRARY_PATH, was it on purpose? |
Indeed, that's what you need The stubs are used by the link step of the compilation, but are not used at run time, since they do not provide any functionality. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
The display of module prefetching calls is now optional, controlled by the
showModulePrefetching
parameter.In the Visual Profile prefetching shows up as light green (or light amber for highlighted modules) to easily distinguish it from the actual event processing.