Cleanup definition of exotic particles

[civanch]

Exotic particles are not part of Geant4 particle table. For Geant4 tracking of such particles they should be defined and corresponding physics processes (decay, ionisation...) should be assigned. This is done inside CustomPhysics sub-library, which is cleaned up in this PR:

1. fixed reading of decay channels from slha data file (end of list of channels was not treated correctly
2. added protection against double instantiation of G4Decay for an exotic particle
3. Exclude decays with zero branching ratios
4. improved LogDebug and LogInfo printouts

Should not affect mainstream MC production.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22615/3959

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/CustomPhysics

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26850/console Started: 2018/03/14 18:18

[cmsbuild]

+1
Tested at: 706eb39
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22615/26850/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22615/26850/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2477528
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2477351
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.22000000009 KiB( 21 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@civanch this change affects the CustomPhysics list, not the standard production one, so it should affect only simulations of exotic final states, am I correct? All the protections look reasonable, was any test done with a generator of some exotic state?

[civanch]

@fabiocos , these fixes where done when I was debugging problem with Chagino and Neutralino run provided by exotica group, there were corresponding shla files and their receipt.

[fabiocos]

+1