Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix in the processing of RunInfo O2O magnet current #22675

Merged
merged 2 commits into from Mar 20, 2018

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Mar 20, 2018

This fix changes the processing of the Magnet Current changes:

  • first the changes within the Run boundaries are considered
  • if no change has been found within Run boundaries, the most recent change is considered

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@ggovi
Copy link
Contributor Author

ggovi commented Mar 20, 2018

please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26976/console Started: 2018/03/20 10:36

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for master.

It involves the following packages:

CondTools/RunInfo

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22675/26976/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2497880
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497703
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.829999999929 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@ggovi
Copy link
Contributor Author

ggovi commented Mar 20, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@ggovi ggovi changed the title Bug fix for magnet current changes Bug fix in the processing of RunInfo O2O magnet current Mar 20, 2018
@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0a4b454 into cms-sw:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants