Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 2017 5TeV pp beamspot parameters from data (minus pixel barycenter) #22717

Merged
merged 1 commit into from Apr 6, 2018
Merged

New 2017 5TeV pp beamspot parameters from data (minus pixel barycenter) #22717

merged 1 commit into from Apr 6, 2018

Conversation

gsfs
Copy link
Contributor

@gsfs gsfs commented Mar 22, 2018

Port of PR#22703 (which was in 9_3_X) to 9_4_X
This beamspot will only be used for MC GEN-SIM in 9_3_X but the DR is in 9_4_X so this should also be in 9_4_X for relval (thanks to Matt N for ponting this out)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gsfs for CMSSW_9_4_X.

It involves the following packages:

IOMC/EventVertexGenerators

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor

civanch commented Mar 23, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27063/console Started: 2018/03/23 09:52

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@gsfs
Copy link
Contributor Author

gsfs commented Mar 23, 2018

Same change ported to:
CMSSW_10_1_X PR#22722

This beamspot will only be used for MC GEN-SIM in 9_3_X

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22717/27063/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2718773
  • DQMHistoTests: Total failures: 105
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2718506
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 107 log files, 9 edm output root files, 26 DQM output files

@civanch
Copy link
Contributor

civanch commented Mar 23, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Apr 6, 2018

+1

@cmsbuild cmsbuild merged commit 9143e21 into cms-sw:CMSSW_9_4_X Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants