Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cfi file for CandIsolatorFromDeposits #2272

Merged
merged 2 commits into from Feb 5, 2014

Conversation

sarafiorendi
Copy link
Contributor

Addition of cfi file for parsing CandIsolatorFromDeposits into ConfDB.
(copy to @battibass and @HuguesBrun)

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2014

A new Pull Request was created by @sarafiorendi for CMSSW_7_0_X.

add cfi file for CandIsolatorFromDeposits

It involves the following packages:

PhysicsTools/IsolationAlgos

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@vadler
Copy link

vadler commented Feb 3, 2014

@sarafiorendi : What is the purpose of this addition?
The exact same configuration is already present in RecoMuon/MuonIsolation/python/muonPFIsolationValues_cff.py as muPFIsoValueCharged03.

@sarafiorendi
Copy link
Contributor Author

I’m asking to add this cfi file since in order to have the CandIsolatorFromDeposits module parsed into ConfDB the cfi file in the python directory of its package (PhysicsTools/IsolationAlgos) is needed.

Cheers,
sara

Il giorno 03/feb/2014, alle ore 16:53, Volker Adler <notifications@github.commailto:notifications@github.com> ha scritto:

@sarafiorendihttps://github.com/sarafiorendi : What is the purpose of this addition?
The exact same configuration is already present in RecoMuon/MuonIsolation/python/muonPFIsolationValues_cff.py as muPFIsoValueCharged03.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2272#issuecomment-33967727.

@vadler
Copy link

vadler commented Feb 3, 2014

I see.
Do you also need that specific configuration for PF muons with iso cone R=0.3? It is a bit in conflict with the generic module name.

@sarafiorendi
Copy link
Contributor Author

We can leave the “src” and “deltaR” fields open if it is preferable.
Do I have to update the file?

Il giorno 03/feb/2014, alle ore 17:26, Volker Adler <notifications@github.commailto:notifications@github.com> ha scritto:

I see.
Do you also need that specific configuration for PF muons with iso cone R=0.3? It is a bit in conflict with the generic module name.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2272#issuecomment-33971241.

@vadler
Copy link

vadler commented Feb 3, 2014

Yes , please update.

@vadler
Copy link

vadler commented Feb 4, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@davidlange6
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2014

ktf added a commit that referenced this pull request Feb 5, 2014
AT fixes -- add cfi file for CandIsolatorFromDeposits
@ktf ktf merged commit 1186ca1 into cms-sw:CMSSW_7_0_X Feb 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants