Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce RunInfo Payload Inspector #22720

Merged
merged 1 commit into from Mar 30, 2018
Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 22, 2018

In this PR, I've added two basic plots for the RunInfo payload inspection, which shall help spotting possible issues without dumping the payload:

  • RunInfoParameters adds a synoptic table of the values of the magnet current stored in the payload and gets a background color according to the content.
    • for "regular" payloads (real run and magnet current is not defaulted to -1) in green:
      ok_payload
    • for "fake" payloads (run number and magnet current to default), in yellow:
      fake_payload
      * for "wrong" payloads (real run number, but magnet current is defaulted) in red:
      wrong_payload
  • RunInfoStopCurrentHistory , provides the time-series of the magnet currents stored in the payload.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

CondCore/RunInfoPlugins

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 22, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27058/console Started: 2018/03/23 00:45

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22720/27058/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2497880
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497703
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.919999999962 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@ggovi
Copy link
Contributor

ggovi commented Mar 27, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar modified the milestones: CMSSW_10_1_X, CMSSW_10_2_X Mar 29, 2018
@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a2ac776 into cms-sw:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants