Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NanoAOD updates to use MiniAODV2 information #22728

Merged
merged 27 commits into from Mar 26, 2018
Merged

NanoAOD updates to use MiniAODV2 information #22728

merged 27 commits into from Mar 26, 2018

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Mar 23, 2018

This uses the new content of MiniAODV2 for NanaAOD processing and fixes few things

Needed for NanoAOD production chained with MiniAOD V2

needs: cms-sw/cmsdist#3873
@gpetruc

veelken and others added 27 commits February 7, 2018 10:55
@veelken
added comment that L2L3Residual JEC are safe to use for MC
f04ccd1
@ktht
Whitelist gen-level W,Z from >10 GeV mass cut
6761ec1 
Issue described here: #114
@gpetruc
Merge pull request #116 from ktht/genWZmassFix
e5daf9d 
Whitelist gen-level W,Z from >10 GeV mass cut
@gpetruc
Merge pull request #104 from veelken/nanoAOD
fb8502c 
added comment that L2L3Residual JEC are safe to use for MC
@arizzi
Merge pull request #111 from HEP-KBFI/fixSIGSEGV
2aa9689 
fixed segmentation violation that occurred in subjet analyses in case…
added photon sc eta EB/EE classification
741aa3c
correct eta boundary
fe61d1c
add new variables to DQM plots
aaff8b6
@gpetruc
Merge pull request #123 from AndrewLevin/add_photon_sc_eta_to_nanoaod
9b36db1 
Add two photon sc eta bits to nanoaod
@gpetruc
Add eras run2_nanoAOD_94XMiniAODv1 and run2_nanoAOD_94XMiniAODv2
dad13dc
@gpetruc
Merge pull request #128 from gpetruc/nanoAOD_94X_eras
cf1b841 
Add eras run2_nanoAOD_94XMiniAODv1 and run2_nanoAOD_94XMiniAODv2
@gpetruc
Merged master from repository cms-nanoAOD with cms-merge-topic
4a9085a
@gpetruc
Merge pull request #131 from cms-nanoAOD/master_to_945cand1
db4a5a7 
Update master to 945cand1
@ktht @arizzi
Sort GenVisTau collection by their pT in GenVisTauProducer
7e3f7a2 
Discussion: #118
@peruzzim @arizzi
Add pfRelIso dR=0.4 calculation with EA to EleIsoValueMapProducer
6988eb5
@peruzzim @arizzi
Switch electrons and muons to Fall17 ID and effective areas
4b8feac
@peruzzim @arizzi
Updated lepton MVA training for 94X Fall17 samples
cfe6645
@peruzzim @arizzi
Correctly initialize lepton-jet variables for lepton MVA when no jet …
687419d 
…is matched
@peruzzim @arizzi
Update DQM content
e9617fd
@peruzzim @arizzi
Fix mistake in effective area migration for muons
aebced2
@peruzzim @arizzi
Fix input variables for 80X muon lepton MVA
39d096f
@knash @arizzi
94X backport
4e50220
@knash @arizzi
merge with PR 22294
38be773
@gpetruc @arizzi
switch 2017 data to 2017 jet ID
1f0decd
@gpetruc @arizzi
move jet era-dependent customizations to jets_cff
bdb186d
@gpetruc @arizzi
update DQM
6318be0
@arizzi
Merge remote-tracking branch 'official-cmssw/CMSSW_9_4_AN_X' into his…
9071477 
…toryRewrittenmaster
@cmsbuild cmsbuild added this to the CMSSW_9_4_AN_X milestone Mar 23, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 24, 2018 •
edited

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3875
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27088/console

@cmsbuild cmsbuild mentioned this pull request Mar 24, 2018
Merged
@cmsbuild
Copy link
Contributor

+1
Tested at: 9071477
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22728/27088/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
9071477
db4a5a7
4a9085a
cf1b841
9b36db1
2aa9689
fb8502c
e5daf9d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22728/27088/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22728/27088/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22728/27088/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 106
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721225
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 110 log files, 9 edm output root files, 27 DQM output files

@arizzi
Copy link
Contributor Author

arizzi commented Mar 25, 2018

+1

cmsbuild added a commit that referenced this pull request Mar 26, 2018
@cmsbuild
Merge pull request #22729 from cms-nanoAOD/masterMergedAndNoData-cmss…
8dd78b7 
…wmaster

NanoAOD updates to use MiniAODV2 information (same as #22728)
@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_AN_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 76b08cf into cms-sw:CMSSW_9_4_AN_X Mar 26, 2018
@fabiocos
Copy link
Contributor

@arizzi @gpetruc after the backport of 9_4_5_cand1 into 9_4_X I do not see the reason not to move also this code into the main 9_4_X branch, for the time being it is ok to test it here in parallel to the master

@fabiocos fabiocos mentioned this pull request Apr 3, 2018
Merged
@gpetruc gpetruc deleted the masterMergedAndNoData branch July 17, 2018 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved comparison-available fully-signed operations-approved orp-approved requires-external tests-approved
Projects
None yet
Milestone
CMSSW_9_4_AN_X
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@arizzi @cmsbuild @smuzaffar @fabiocos @veelken @ktht @gpetruc @peruzzim @knash