Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEMGeometryParsFromDD fix #22730

Merged
merged 1 commit into from Mar 26, 2018
Merged

Conversation

jshlee
Copy link
Contributor

@jshlee jshlee commented Mar 23, 2018

Bug fix for GEMGeometryParsFromDD.
Both GEMGeometryBuilderFromCondDB and GEMGeometryParsFromDD was dividing by cm making the gem chamber size 10 times smaller in GEMRECO_Geometry_10YV3.

New gem geometry in DB is needed using this PR to fix the issue found in #22619.

@ianna @slava77 @arunhep @lpernie

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jshlee (Jason Lee) for master.

It involves the following packages:

Geometry/GEMGeometryBuilder

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@ghellwig, @dildick this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27083/console Started: 2018/03/23 19:28

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22730/27083/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2498300
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2498123
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.930000000109 KiB( 22 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@civanch
Copy link
Contributor

civanch commented Mar 25, 2018

+1

@kpedro88
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@ianna @arunhep @lpernie do we have this update propagated to GT as well?

@civanch
Copy link
Contributor

civanch commented Mar 26, 2018

@fabiocos , I think so...

@arunhep
Copy link
Contributor

arunhep commented Mar 26, 2018

@ianna @arunhep @lpernie do we have this update propagated to GT as well?

we still have in latest GT, this tag : GEMRECO_Geometry_10YV3
so if this is not the correct tag then i dont think so.

@jshlee
Copy link
Contributor Author

jshlee commented Mar 26, 2018

@arunhep - GEMRECO_Geometry_10YV3 is the one with the problem.
The very old one GEMRECO_Geometry_92YV5 is ok.
Or preferably, using this PR would be better.

Could we have 101X_upgrade2018_realistic_v5 updated with either GEMRECO_Geometry_92YV5 or using this PR.

@fabiocos
Copy link
Contributor

+1

but we need to update the GT as well

@cmsbuild cmsbuild merged commit 1c0df66 into cms-sw:master Mar 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants