Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HGCAL trigger: Fix hOverE computation in HGCalClusterT #22757

Merged
merged 1 commit into from Apr 2, 2018

Conversation

jbsauvan
Copy link
Contributor

@jbsauvan jbsauvan commented Mar 27, 2018

Fix hOverE computation in HGCalClusterT: propagate changes done in the constituents format (map instead of vector)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

DataFormats/L1THGCal

@nsmith-, @rekovic, @cmsbuild, @thomreis, @kpedro88 can you please review it and eventually sign? Thanks.
@amarini, @rovere, @lgray this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor

rekovic commented Mar 27, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 27, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27141/console Started: 2018/03/27 16:37

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22757/27141/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2501580
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2501403
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.19000000014 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@rekovic
Copy link
Contributor

rekovic commented Mar 28, 2018

+1

@rekovic
Copy link
Contributor

rekovic commented Mar 28, 2018

@jbsauvan
Please add a description of this PR at the top.

@kpedro88
Copy link
Contributor

+1
should this be backported to 93X for L1T studies?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@smuzaffar smuzaffar modified the milestones: CMSSW_10_1_X, CMSSW_10_2_X Mar 29, 2018
@jbsauvan
Copy link
Contributor Author

Hi @kpedro88
It doesn't need to be backported. The HGCAL objects produced are fine without this fix.

@fabiocos
Copy link
Contributor

fabiocos commented Apr 2, 2018

+1

@cmsbuild cmsbuild merged commit bc21770 into cms-sw:master Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants