RecoMuon/MuonIsolation: Fixes for these clang warnings: -Wlogical-not-parentheses -Woverloaded-virtual

[gartung]

/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/llvm/5.0.0-jpkldn/bin/clang++ -c -DGNU_GCC -D_GNU_SOURCE -DTBB_USE_GLIBCXX_VERSION=60300 -DBOOST_SPIRIT_THREADSAFE -DPHOENIX_THREADSAFE -DCMSSW_GIT_HASH='CMSSW_10_1_CLANG_X_2018-03-26-2300' -DPROJECT_NAME='CMSSW' -DPROJECT_VERSION='CMSSW_10_1_CLANG_X_2018-03-26-2300' -I/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/lcg/root/6.10.09-jpkldn/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/boost/1.63.0-jpkldn/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/pcre/8.37-oenich/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/bz2lib/1.0.6/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/clhep/2.4.0.0-jpkldn/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/gsl/2.2.1/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/hepmc/2.06.07-oenich/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/libuuid/2.22.2/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/python/2.7.11-jpkldn/include/python2.7 -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/tbb/2018_U1/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/cms/vdt/0.4.0/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/xerces-c/3.1.3/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/xz/5.2.2-oenich/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/zlib-x86_64/1.2.11/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/md5/1.0.0/include -I/build/cmsbld/jenkins/workspace/build-any-ib/w/slc6_amd64_gcc630/external/tinyxml/2.5.3-jpkldn/include -O2 -pthread -pipe -Werror=main -Werror=pointer-arith -Werror=overlength-strings -Wno-vla -Werror=overflow -std=c++1z -ftree-vectorize -Wstrict-overflow -Werror=array-bounds -Werror=type-limits -fvisibility-inlines-hidden -fno-math-errno --param vect-max-version-for-alias-checks=50 -Xassembler --compress-debug-sections -msse3 -felide-constructors -fmessage-length=0 -Wall -Wno-long-long -Wreturn-type -Wunused -Wparentheses -Wno-deprecated -Werror=return-type -Werror=missing-braces -Werror=unused-value -Werror=address -Werror=format -Werror=sign-compare -Werror=write-strings -Werror=delete-non-virtual-dtor -Werror=strict-aliasing -Werror=narrowing -Werror=uninitialized -Werror=reorder -Werror=unused-variable -Werror=conversion-null -Werror=switch -fdiagnostics-show-option -Wno-unused-local-typedefs -Wno-attributes -Wno-c99-extensions -Wno-c++11-narrowing -D__STRICT_ANSI__ -Wno-unused-private-field -Wno-unknown-pragmas -Wno-unused-command-line-argument -Wno-unknown-warning-option -ftemplate-depth=512 -Wno-error=potentially-evaluated-expression -Wno-error=unused-variable -Wno-error=unused-variable -Wno-error=unused-variable -DBOOST_DISABLE_ASSERTS -fPIC -MMD -MF tmp/slc6_amd64_gcc630/src/RecoMuon/MuonIsolation/plugins/RecoMuonMuonIsolationPlugins/CutsIsolatorWithCorrection.d /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoMuon/MuonIsolation/plugins/CutsIsolatorWithCorrection.cc -o tmp/slc6_amd64_gcc630/src/RecoMuon/MuonIsolation/plugins/RecoMuonMuonIsolationPlugins/CutsIsolatorWithCorrection.o
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoMuon/MuonIsolation/plugins/CaloExtractorByAssociator.cc:108:7: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
if (! theDepositInstanceLabels[0].compare(0,1, std::string("e")) == 0
^ ~~
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoMuon/MuonIsolation/plugins/CaloExtractorByAssociator.cc:108:7: note: add parentheses after the '!' to evaluate the comparison first
if (! theDepositInstanceLabels[0].compare(0,1, std::string("e")) == 0
^
( )
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoMuon/MuonIsolation/plugins/CaloExtractorByAssociator.cc:108:7: note: add parentheses around left hand side expression to silence this warning
if (! theDepositInstanceLabels[0].compare(0,1, std::string("e")) == 0
^
( )
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoMuon/MuonIsolation/plugins/CaloExtractorByAssociator.cc:109:10: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
|| ! theDepositInstanceLabels[1].compare(0,1, std::string("h")) == 0
^ ~~
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoMuon/MuonIsolation/plugins/CaloExtractorByAssociator.cc:109:10: note: add parentheses after the '!' to evaluate the comparison first
|| ! theDepositInstanceLabels[1].compare(0,1, std::string("h")) == 0
^
( )
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoMuon/MuonIsolation/plugins/CaloExtractorByAssociator.cc:109:10: note: add parentheses around left hand side expression to silence this warning
|| ! theDepositInstanceLabels[1].compare(0,1, std::string("h")) == 0
^
( )
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoMuon/MuonIsolation/plugins/CaloExtractorByAssociator.cc:110:10: warning: logical not is only applied to the left hand side of this comparison [-Wlogical-not-parentheses]
|| ! theDepositInstanceLabels[2].compare(0,2, std::string("ho")) == 0){
^ ~~
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoMuon/MuonIsolation/plugins/CaloExtractorByAssociator.cc:110:10: note: add parentheses after the '!' to evaluate the comparison first
|| ! theDepositInstanceLabels[2].compare(0,2, std::string("ho")) == 0){
^
( )
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoMuon/MuonIsolation/plugins/CaloExtractorByAssociator.cc:110:10: note: add parentheses around left hand side expression to silence this warning
|| ! theDepositInstanceLabels[2].compare(0,2, std::string("ho")) == 0){
^
( )
1 warning generated.

In file included from /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoMuon/MuonIsolation/plugins/ExtractorFromDeposits.cc:1:
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/RecoMuon/MuonIsolation/plugins/ExtractorFromDeposits.h:29:28: warning: 'muonisolation::ExtractorFromDeposits::deposit' hides overloaded virtual functions [-Woverloaded-virtual]
virtual reco::IsoDeposit deposit (const edm::Event & ev, const edm::EventSetup & evSetup,
^
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/PhysicsTools/IsolationAlgos/interface/IsoDepositExtractor.h:44:32: note: hidden overloaded virtual function 'reco::isodeposit::IsoDepositExtractor::deposit' declared here: type mismatch at 3rd parameter ('const reco::TrackBaseRef &' (aka 'const RefToBasereco::Track &') vs 'const reco::TrackRef &' (aka 'const Ref<vectorreco::Track > &'))
virtual reco::IsoDeposit deposit(const edm::Event & ev, const edm::EventSetup & evSetup,
^
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/PhysicsTools/IsolationAlgos/interface/IsoDepositExtractor.h:51:32: note: hidden overloaded virtual function 'reco::isodeposit::IsoDepositExtractor::deposit' declared here: type mismatch at 3rd parameter ('const reco::Candidate &' vs 'const reco::TrackRef &' (aka 'const Ref<vectorreco::Track > &'))
virtual reco::IsoDeposit deposit(const edm::Event & ev, const edm::EventSetup & evSetup,
^
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/PhysicsTools/IsolationAlgos/interface/IsoDepositExtractor.h:60:32: note: hidden overloaded virtual function 'reco::isodeposit::IsoDepositExtractor::deposit' declared here: type mismatch at 3rd parameter ('const reco::CandidateBaseRef &' (aka 'const RefToBasereco::Candidate &') vs 'const reco::TrackRef &' (aka 'const Ref<vectorreco::Track > &'))
virtual reco::IsoDeposit deposit(const edm::Event & ev, const edm::EventSetup & evSetup,
^
1 warning generated.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22762/4134

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

RecoMuon/MuonIsolation

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @folguera, @abbiendi, @jhgoh, @echapon, @calderona, @HuguesBrun, @drkovalskyi, @battibass, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27147/console Started: 2018/03/27 22:37

[cmsbuild]

+1
Tested at: e537dba
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22762/27147/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22762/27147/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2501580
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2501403
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.16000000005 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[slava77]

after another look, I think that ExtractorFromDeposits.h should be fixed.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22762/4203

[cmsbuild]

Pull request #22762 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27232/console Started: 2018/04/02 18:05

[cmsbuild]

+1
Tested at: f3059c7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22762/27232/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22762/27232/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22762/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2502154
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2501977
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.999999999964 KiB( 23 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[slava77]

+1

for #22762 f3059c7

• technical
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1