Add asserts to avoid null pointer dereferences #2284
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, several relvals in the 7_1_X IB's have segfaulted in RootInputFileSequence::readOneSpecified().
That function dereferences a pointer without first checking for a null pointer.
This function adds an assert to that function, and to a few other functions in the same source file, to always check RootInputFileSequence::rootFile_, a pointer, for null before dereferencing it.
The segfaults are not reproducible, but this pull request may help solve the problem by checking for null pointer dereferences.
Some standardization of white space in the same file was also done, and one iterator loop was replaced by a C++11 range for loop.
range for loop.