Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport Changed CorrPCCProducer from EDProducer to DQMEDAnalyzer for LumiPOG #22870

Merged
merged 3 commits into from May 2, 2018

Conversation

samhiggie
Copy link
Contributor

Backport for PR: #22868
Please visit that thread for discussion.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2018

A new Pull Request was created by @samhiggie for CMSSW_10_1_X.

It involves the following packages:

Calibration/LumiAlCaRecoProducers

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented Apr 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27327/console Started: 2018/04/05 22:01

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2018

-1

Tested at: 5af58c6

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22870/27327/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

The relvals timed out after 2 hours.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2018

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@capalmer85
Copy link
Contributor

"The relvals timed out after 2 hours." Doesn't seem related to the PR. I don't think it started running any relevant part of the matrix.

@arunhep
Copy link
Contributor

arunhep commented Apr 6, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27339/console Started: 2018/04/06 11:14

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 6, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

Pull request #22870 was updated. @prebello, @arunhep, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @cerminar, @GurpreetSinghChahal, @lpernie can you please check and sign again.

@arunhep
Copy link
Contributor

arunhep commented Apr 25, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 25, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27640/console Started: 2018/04/25 10:38

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22870/27640/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2506331
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2506154
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.012 KiB( 28 files compared)
  • DQMHistoSizes: changed ( 140.53,... ): 0.007 KiB L1T/EventInfo
  • DQMHistoSizes: changed ( 140.53,... ): 0.006 KiB L1TEMU/EventInfo
  • DQMHistoSizes: changed ( 140.53,... ): 0.005 KiB HLT/EventInfo
  • DQMHistoSizes: changed ( 140.53,... ): 0.005 KiB Muons/EventInfo
  • DQMHistoSizes: changed ( 140.53,... ): 0.004 KiB Ecal/EventInfo
  • DQMHistoSizes: changed ( 140.53,... ): 0.004 KiB Pixel/EventInfo
  • DQMHistoSizes: changed ( 140.53,... ): 0.003 KiB L1T/L1TriggerVsReco
  • DQMHistoSizes: changed ( 140.53 ): 0.002 KiB DT/EventInfo
  • DQMHistoSizes: changed ( 140.53,... ): 0.002 KiB RPC/EventInfo
  • DQMHistoSizes: changed ( 150.0 ): 0.021 KiB HLT/EventInfo
  • DQMHistoSizes: changed ( 150.0 ): ...
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@kpedro88
Copy link
Contributor

+1

@fabozzi
Copy link
Contributor

fabozzi commented Apr 26, 2018

+1

@arunhep
Copy link
Contributor

arunhep commented Apr 26, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented May 2, 2018

+1

@cmsbuild cmsbuild merged commit 35f1648 into cms-sw:CMSSW_10_1_X May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants