Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT in autoCond for 10_1_1, combination of PR 22834 and 22893 #22897

Merged
merged 5 commits into from Apr 7, 2018

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Apr 7, 2018

The GT for 10_1_1 in #22834 has a problem causing crashes in 2016 test workflows. The fix #22893 anyway needs to be rebased on the former. This PR combines the two.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2018

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_10_1_X.

It involves the following packages:

Configuration/AlCa

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @ghellwig, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 7, 2018

@arunhep @lpernie FYI , #22834 was rebased on the HEAD and then I added the modification of #22893, see the commits

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 7, 2018

please test workflow 136.77,136.778

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27379/console Started: 2018/04/07 20:13

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 7, 2018

AlCa experts already approved separately the two input PRs, and the master version looks to run smoothly (once the fix is applied)

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 7, 2018

+1

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 7, 2018

merge

@cmsbuild cmsbuild merged commit c052495 into cms-sw:CMSSW_10_1_X Apr 7, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2018

-1

Tested at: ab3710f

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22897/27379/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

The relvals timed out after 2 hours.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 7, 2018

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 8, 2018

@smuzaffar I guess that the test failure is due to a timeout because of the overlap with the main rebuild of Sunday morning, the tests had passed in the input PRs.

@fabiocos fabiocos deleted the fc-autoCond101X branch April 12, 2018 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants