Strip hit eff update 10_2_x

[jlagram]

Update of the CalibTracker/SiStripHitEfficiency package used for measuring hit efficiency.
Mainly new selections added and update of tree format.

[cmsbuild]

@jlagram, CMSSW_10_2_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22932/4316

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22932/4316/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22932/4316/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22932/4321

[cmsbuild]

A new Pull Request was created by @jlagram for master.

It involves the following packages:

CalibTracker/SiStripHitEfficiency

@cmsbuild, @franzoni, @arunhep, @cerminar, @lpernie can you please review it and eventually sign? Thanks.
@echabert, @mmusich, @gbenelli, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@arunhep @lpernie can tests be started here?
Fast review is appreciated (we foresee to backport to 10_1 as well)

[lpernie]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27457/console Started: 2018/04/12 15:57

[cmsbuild]

+1
Tested at: f592fa2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22932/27457/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22932/27457/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2505375
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2505198
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 23 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[arunhep]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@arunhep for my understanding, in which test wf is this supposed to run, if any? Not in the basic ones as far as I can see...

[mmusich]

@fabiocos is not run in any relval, if that's what you mean, but I add some time ago a unit test that (among other things) runs this code as well: testProduceCalibrationTree_cfg.py

[fabiocos]

@mmusich ok, so in practice there has been a standalone test of this PR, right?

[fabiocos]

+1

[mmusich]

@fabiocos, in practice in the PR tests themselves unfortunately nothing was run, excepted the compilation, because the package in which the test resides was not touched, but we (Tracker DPG) tested it extensively.
This code by the way is sort of "private" in the sense that Tier-0 doesn't run it, but we use it for data monitoring purposes within the DPG.
The code changes proposed here are already running in our calibration tree production since first collisions without hiccups.
Let me attach here two plots from @jlagram to show the effect of the changes by "replaying" the workflow on a 2017 run:

New version:

Old version:

[fabiocos]

@mmusich thanks for the reference documentation, I merged the code for AlCa use